Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ARCH to TARGETARCH for multi platform build by docker buildx #2320

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

morlay
Copy link
Contributor

@morlay morlay commented Jun 30, 2020

Which problem is this PR solving?

Short description of the changes

now could build local by

make build-ui
make build-query GOOS=linux GOARCH=arm64
make build-all-in-one GOOS=linux GOARCH=arm64
make build-query GOOS=linux GOARCH=amd64
make build-all-in-one GOOS=linux GOARCH=amd64
repo=jaegertracing/all-in-one # all change to custom repo
docker buildx build --platform=linux/amd64,linux/arm64 --push -f cmd/all-in-one/Dockerfile -t $repo:latest cmd/all-in-one

demo https://hub.docker.com/r/querycap/jaegertracing-all-in-one/tags

In travis, need to setup buildx with qemu https://github.com/crazy-max/ghaction-docker-buildx

@morlay
Copy link
Contributor Author

morlay commented Jun 30, 2020

mv all build in docker will be make docker buildx happy.

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2320   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         203      203           
  Lines       10291    10291           
=======================================
  Hits         9899     9899           
  Misses        336      336           
  Partials       56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a27f1...1ed2940. Read the comment docs.

Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please apply the change to all docker files?

Signed-off-by: Morlay <morlay.null@gmail.com>
@morlay
Copy link
Contributor Author

morlay commented Jul 1, 2020

@pavolloffay sure.

@morlay morlay requested a review from pavolloffay July 1, 2020 08:37
@pavolloffay pavolloffay changed the title fix: ARG ARCH to TARGETARCH for multi platform by docker buildx Rename ARCH to TARGETARCH for multi platform build by docker buildx Jul 1, 2020
@pavolloffay pavolloffay merged commit 221b708 into jaegertracing:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants