Preparing release 1.19.0 #2415
Preparing release 1.19.0 #2415
Conversation
| * Add native OTEL ES exporter ([#2295](https://github.com/jaegertracing/jaeger/pull/2295), [@pavolloffay](https://github.com/pavolloffay)) | ||
| * Define busy error type in processor ([#2314](https://github.com/jaegertracing/jaeger/pull/2314), [@pavolloffay](https://github.com/pavolloffay)) | ||
| * Use gRPC instead of tchannel in hotrod ([#2307](https://github.com/jaegertracing/jaeger/pull/2307), [@pavolloffay](https://github.com/pavolloffay)) | ||
| * TLS support for gRPC Query server ([#2297](https://github.com/jaegertracing/jaeger/pull/2297), [@jan25](https://github.com/jan25)) |
There was a problem hiding this comment.
We need to double-check this one. The current master does not show the option that this one brought. Was it reverted?
There was a problem hiding this comment.
@jpkrohling any update on this one? Should it be removed from the change log and moved to the next release?
There was a problem hiding this comment.
Ok, I tracked this down: #2337 (review)
Basically, the code is there, but the flag isn't being registered. In the end, this is good as this doesn't expose the flag to users, otherwise we'd have to wait for the PR to split ports before doing this release (or revert this PR).
It would probably be worth adding a "known issues" section to the changelog. Like:
The pull request #2297 aimed to add TLS support for the gRPC Query server but the flag registration is missing, so that this feature can't be used at the moment. A fix is planned for the next Jaeger version (1.20).
So, we are good to go, IMO.
There was a problem hiding this comment.
Additional "Known Issues" section added.
|
is #1952 going to be a problem for the release? |
|
@yurishkuro Looks like it has been failing for a couple of months. So yes will likely cause the release to fail. |
|
First change to fail was #2330 - but doesn't contain anything travis/build related. |
Signed-off-by: Gary Brown <gary@brownuk.com> Update CHANGELOG.md Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
…erver Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
- Coverage 95.58% 95.57% -0.01%
==========================================
Files 208 208
Lines 10678 10678
==========================================
- Hits 10207 10206 -1
- Misses 399 400 +1
Partials 72 72
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| @@ -14,6 +14,49 @@ Changes by Version | |||
|
|
|||
| ### UI Changes | |||
|
|
|||
| 1.19.0 (2020-08-25) | |||
There was a problem hiding this comment.
nit: update the date to match the release date
Signed-off-by: Gary Brown <gary@brownuk.com>
Signed-off-by: Gary Brown gary@brownuk.com