Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log deprecation warning only when deprecated flags are set #2479

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2479 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
+ Coverage   95.50%   95.53%   +0.02%     
==========================================
  Files         208      208              
  Lines       10756    10759       +3     
==========================================
+ Hits        10273    10279       +6     
+ Misses        407      405       -2     
+ Partials       76       75       -1     
Impacted Files Coverage Δ
cmd/query/app/flags.go 100.00% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 96.49% <0.00%> (-0.30%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️
cmd/query/app/server.go 90.69% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37eaced...e5d15f1. Read the comment docs.

@pavolloffay pavolloffay merged commit 2c5c277 into jaegertracing:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants