Clarify deadlock panic message #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
objectiser
reviewed
Oct 29, 2020
| @@ -68,7 +68,8 @@ func newDeadlockDetector(metricsFactory metrics.Factory, logger *zap.Logger, int | |||
| time.Sleep(time.Second) // Allow time to flush metric | |||
|
|
|||
| buf := make([]byte, 1<<20) | |||
| logger.Panic("No messages processed in the last check interval", | |||
| logger.Panic("No messages processed in the last check interval, possible deadlock, exiting. "+ | |||
There was a problem hiding this comment.
LGTM - only one suggestion might be to remove the stack trace, so it doesn't look like an unexpected exit?
Signed-off-by: Yuri Shkuro <github@ysh.us>
objectiser
approved these changes
Oct 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 95.31% 95.05% -0.26%
==========================================
Files 208 209 +1
Lines 9285 9368 +83
==========================================
+ Hits 8850 8905 +55
- Misses 356 385 +29
+ Partials 79 78 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2603.