Return buffers to pool on network errors or queue overflow #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of sync.Pool requires a .Put for every .Get. On success, the downstream ThriftProcessor invoked .Put via .DataRecd but in error cases there seems to be a leak. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Codecov Report
@@ Coverage Diff @@
## master #2609 +/- ##
==========================================
- Coverage 95.07% 95.06% -0.01%
==========================================
Files 209 209
Lines 9366 9368 +2
==========================================
+ Hits 8905 8906 +1
- Misses 385 386 +1
Partials 76 76
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Oct 30, 2020
yurishkuro
changed the title
|
Thanks! |
|
Oh, sorry, I hate that the commit comment I made was incorrect 😭 For some reason I always assumed sync.Pool retained a reference to the objects, allocated as an array or similar.. |
|
no worries, I changed the commit message during merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
sync.Poolrequires a.Putfor every.Get.On success, the downstream
ThriftProcessorinvoked.Putvia.DataRecdbut in error cases there seems to be a leak.
Which problem is this PR solving?
I think I found a leak when reviewing this code for deadlock-related issues.
Short description of the changes
Free memory in error cases.