Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/queue] Add StartConsumersWithFactory function #2714

Merged
merged 5 commits into from
Jan 7, 2021
Merged

[pkg/queue] Add StartConsumersWithFactory function #2714

merged 5 commits into from
Jan 7, 2021

Commits on Jan 5, 2021

  1. [pkg/queue] Add StartConsumersWithFactory function 

    This provides a way to keep state for each consumer of a bounded queue,
which is useful in certain performance-critical setups. Fixes jaegertracing#2685.

Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
    @mx-psi
    mx-psi committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    580db76 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Refactor bounded queue tests to extract common parts 

    The common part with the assertions was moved to a new `checkQueue`
function that is used by `TestBoundedQueue` and `TestBoundedQueueWithFactory`.

Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
    @mx-psi
    mx-psi committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    26a349e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Use http.HandlerFunc pattern for getting a Consumer from a callback 

    Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
    @mx-psi
    mx-psi committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d968bd5 View commit details
    Browse the repository at this point in the history

  2. Address review comment about unit tests 

    Refactor unit tests using a `helper` function that takes a function
to start consumers.

Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
    @mx-psi
    mx-psi committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c955e1d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mx-psi/add-queue-factory

    @mx-psi
    mx-psi committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ab42619 View commit details
    Browse the repository at this point in the history