#2048 - Support Elasticsearch ILM for managing jaeger indices #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2796 +/- ##
==========================================
+ Coverage 95.91% 95.94% +0.03%
==========================================
Files 218 221 +3
Lines 9620 9693 +73
==========================================
+ Hits 9227 9300 +73
Misses 324 324
Partials 69 69
Continue to review full report at Codecov.
|
|
codecov is acting out again, but the report looks ok to merge: https://codecov.io/github/jaegertracing/jaeger/commit/49e6f871181214f3a29142c074660089692d8f9d |
albertteoh
approved these changes
Feb 7, 2021
yurishkuro
reviewed
Feb 7, 2021
yurishkuro
previously approved these changes
Feb 13, 2021
…dices Signed-off-by: santosh <bsantosh@thoughtworks.com>
Signed-off-by: santosh <bsantosh@thoughtworks.com>
mergify
bot
dismissed
yurishkuro’s stale review
Pull request has been modified.
Signed-off-by: santosh <bsantosh@thoughtworks.com>
|
Rebased with master @yurishkuro - Kindly approve |
albertteoh
approved these changes
Feb 13, 2021
| @@ -232,6 +232,12 @@ func addFlags(flagSet *flag.FlagSet, nsConfig *namespaceConfig) { | |||
| "Use read and write aliases for indices. Use this option with Elasticsearch rollover "+ | |||
| "API. It requires an external component to create aliases before startup and then performing its management. "+ | |||
| "Note that "+nsConfig.namespace+suffixMaxSpanAge+" will influence trace search window start times.") | |||
| flagSet.Bool( | |||
There was a problem hiding this comment.
Yes, that's fine @bhiravabhatla.
Ashmita152
reviewed
Feb 13, 2021
Ashmita152
reviewed
Feb 13, 2021
cmd/opentelemetry/app/exporter/elasticsearchexporter/exporter.go
Outdated
Show resolved
Hide resolved
cmd/opentelemetry/app/exporter/elasticsearchexporter/integration_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: santosh <bsantosh@thoughtworks.com>
|
@yurishkuro Can we merge this PR to master - so that I can take rebase and create a new branch to work on for followup PRs. |
yurishkuro
approved these changes
Feb 15, 2021
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: santosh bsantosh@thoughtworks.com
Which problem is this PR solving?
Short description of the changes