Preparing release v1.22.0 #2826

albertteoh · 2021-02-23T03:50:50Z

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

Prepares master for 1.22.0 release
Fixes When to release 1.22 #2734

Short description of the changes

Update changelog following instructions from RELEASE.md
The excluded PRs (not including dependabot PRs) generated from make changelog are as follows:

* Pass context to goroutine ([#2823](https://github.com/jaegertracing/jaeger/pull/2823), [@albertteoh](https://github.com/albertteoh))	
* 2814 - Throw an error when --es.use-ilm is set without --es.use-aliases ([#2820](https://github.com/jaegertracing/jaeger/pull/2820), [@bhiravabhatla](https://github.com/bhiravabhatla))	
* Add hotrod in release and push all tags ([#2812](https://github.com/jaegertracing/jaeger/pull/2812), [@Ashmita152](https://github.com/Ashmita152))	
* Fix default username when pushing container images to Quay.io ([#2809](https://github.com/jaegertracing/jaeger/pull/2809), [@jpkrohling](https://github.com/jpkrohling))	
* Clean up go.sum to support building with Go 1.16 ([#2773](https://github.com/jaegertracing/jaeger/pull/2773), [@gsagula](https://github.com/gsagula))	
* Remove the labeler workflow ([#2770](https://github.com/jaegertracing/jaeger/pull/2770), [@jpkrohling](https://github.com/jpkrohling))	
* Add dependabot to the repository ([#2759](https://github.com/jaegertracing/jaeger/pull/2759), [@jpkrohling](https://github.com/jpkrohling))	
* Update gogo/protobuf to 1.3.2 ([#2758](https://github.com/jaegertracing/jaeger/pull/2758), [@jpkrohling](https://github.com/jpkrohling))	
* Remove needs-triage labeler ([#2761](https://github.com/jaegertracing/jaeger/pull/2761), [@jpkrohling](https://github.com/jpkrohling))	
* Divide build-binaries job to multiple jobs per platform ([#2757](https://github.com/jaegertracing/jaeger/pull/2757), [@Ashmita152](https://github.com/Ashmita152))	
* Fix errors in build-binaries task ([#2754](https://github.com/jaegertracing/jaeger/pull/2754), [@Ashmita152](https://github.com/Ashmita152))	
* Github action for jaeger packages and docker image ([#2740](https://github.com/jaegertracing/jaeger/pull/2740), [@Ashmita152](https://github.com/Ashmita152))	
* Fix Grafana example ([#2750](https://github.com/jaegertracing/jaeger/pull/2750), [@Daverkex](https://github.com/Daverkex))	
* Add changelog entry for Query server TLS support ([#2746](https://github.com/jaegertracing/jaeger/pull/2746), [@rjs211](https://github.com/rjs211))	
* Enable stale bot for PRs and questions ([#2731](https://github.com/jaegertracing/jaeger/pull/2731), [@yurishkuro](https://github.com/yurishkuro))	
* Transition black-adder and tiffon to Emeritus Maintainers ([#2735](https://github.com/jaegertracing/jaeger/pull/2735), [@yurishkuro](https://github.com/yurishkuro))	
* Add ability to remove inactive maintainers; introduce Emeritus status ([#2733](https://github.com/jaegertracing/jaeger/pull/2733), [@yurishkuro](https://github.com/yurishkuro))	
* Update UI for js config ([#2732](https://github.com/jaegertracing/jaeger/pull/2732), [@th3M1ke](https://github.com/th3M1ke))
* [tests] Increase timeout for TestGRPCResolverRoundRobin ([#2729](https://github.com/jaegertracing/jaeger/pull/2729), [@yurishkuro](https://github.com/yurishkuro))	
* [refactor] Minor clean-up of #2657 ([#2728](https://github.com/jaegertracing/jaeger/pull/2728), [@yurishkuro](https://github.com/yurishkuro))
* Fix flaky TestHotReloadUIConfigTempFile ([#2713](https://github.com/jaegertracing/jaeger/pull/2713), [@albertteoh](https://github.com/albertteoh))	
* Clean-up "tcollector" references ([#2704](https://github.com/jaegertracing/jaeger/pull/2704), [@sniperking1234](https://github.com/sniperking1234))	
* Add github actions for hotrod ci job ([#2702](https://github.com/jaegertracing/jaeger/pull/2702), [@Ashmita152](https://github.com/Ashmita152))
* Fix misleading use-alias help doc ([#2692](https://github.com/jaegertracing/jaeger/pull/2692), [@albertteoh](https://github.com/albertteoh))	
* Replace deprecated function in command_test.go ([#2690](https://github.com/jaegertracing/jaeger/pull/2690), [@sniperking1234](https://github.com/sniperking1234))	
* Remove Question issue type and add Discussions ([#2689](https://github.com/jaegertracing/jaeger/pull/2689), [@yurishkuro](https://github.com/yurishkuro))
* Fix typo in hotrod README.md ([#2683](https://github.com/jaegertracing/jaeger/pull/2683), [@sniperking1234](https://github.com/sniperking1234))
* Add gh action for crossdock and crossdock otel ci jobs ([#2681](https://github.com/jaegertracing/jaeger/pull/2681), [@Ashmita152](https://github.com/Ashmita152))	
* Add logz.io to adopters list ([#2680](https://github.com/jaegertracing/jaeger/pull/2680), [@albertteoh](https://github.com/albertteoh))	
* Fix issue for Elasticsearch CI failures ([#2678](https://github.com/jaegertracing/jaeger/pull/2678), [@Ashmita152](https://github.com/Ashmita152))	
* Fix the unbound variable error on all-in-one image build ([#2675](https://github.com/jaegertracing/jaeger/pull/2675), [@Ashmita152](https://github.com/Ashmita152))	
* Add github action for elasticsearch otel integration tests ([#2671](https://github.com/jaegertracing/jaeger/pull/2671), [@Ashmita152](https://github.com/Ashmita152))	
* Address review comments from #2655 ([#2673](https://github.com/jaegertracing/jaeger/pull/2673), [@albertteoh](https://github.com/albertteoh))	
* Rename GH Action workflows ([#2672](https://github.com/jaegertracing/jaeger/pull/2672), [@yurishkuro](https://github.com/yurishkuro))	
* Move cert loading failure assertion on client public key write ([#2655](https://github.com/jaegertracing/jaeger/pull/2655), [@albertteoh](https://github.com/albertteoh))	
* Fix issue with all-in-one build ([#2670](https://github.com/jaegertracing/jaeger/pull/2670), [@Ashmita152](https://github.com/Ashmita152))	
* Fix issue with all-in-one build ([#2669](https://github.com/jaegertracing/jaeger/pull/2669), [@Ashmita152](https://github.com/Ashmita152))	
* Fix docker login issue with all-in-one build ([#2668](https://github.com/jaegertracing/jaeger/pull/2668), [@Ashmita152](https://github.com/Ashmita152))	
* Fix and minor improvements to all-in-one github action ([#2667](https://github.com/jaegertracing/jaeger/pull/2667), [@Ashmita152](https://github.com/Ashmita152))	
* Add github action for jaeger all-in-one image ([#2663](https://github.com/jaegertracing/jaeger/pull/2663), [@Ashmita152](https://github.com/Ashmita152))	
* Add protogen validation test github actions workflow ([#2662](https://github.com/jaegertracing/jaeger/pull/2662), [@Ashmita152](https://github.com/Ashmita152))	
* Fix for failures in badger integration tests ([#2660](https://github.com/jaegertracing/jaeger/pull/2660), [@Ashmita152](https://github.com/Ashmita152))	
* Clean-up GH action names ([#2661](https://github.com/jaegertracing/jaeger/pull/2661), [@yurishkuro](https://github.com/yurishkuro))	
* Add github action for jaeger integration tests ([#2649](https://github.com/jaegertracing/jaeger/pull/2649), [@Ashmita152](https://github.com/Ashmita152))	
* Fix flaky tbuffered server test ([#2635](https://github.com/jaegertracing/jaeger/pull/2635), [@pkositsyn](https://github.com/pkositsyn))	
* [tests]: call Close() to cleanup temporary directory ([#2651](https://github.com/jaegertracing/jaeger/pull/2651), [@zhijianli88](https://github.com/zhijianli88))	
* Clean-up Badger factory Close() behavior ([#2643](https://github.com/jaegertracing/jaeger/pull/2643), [@yurishkuro](https://github.com/yurishkuro))
* Add github action for unit test and coverage ([#2648](https://github.com/jaegertracing/jaeger/pull/2648), [@Ashmita152](https://github.com/Ashmita152))	
* Fix flaky TestReload ([#2646](https://github.com/jaegertracing/jaeger/pull/2646), [@albertteoh](https://github.com/albertteoh))	
* Add PalFish to ADOPTERS ([#2641](https://github.com/jaegertracing/jaeger/pull/2641), [@ZhengHe-MD](https://github.com/ZhengHe-MD))	
* Fix unit test fail ([#2636](https://github.com/jaegertracing/jaeger/pull/2636), [@Hellcatlk](https://github.com/Hellcatlk))	
* [anonymizer] Update Makefile and Dockerfile ([#2632](https://github.com/jaegertracing/jaeger/pull/2632), [@Ashmita152](https://github.com/Ashmita152))

Signed-off-by: albertteoh <albert.teoh@logz.io>

codecov · 2021-02-23T04:02:42Z

Codecov Report

Merging #2826 (3cf43ce) into master (4b51f68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2826   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         221      221           
  Lines        9696     9696           
=======================================
  Hits         9303     9303           
  Misses        324      324           
  Partials       69       69

Impacted Files	Coverage Δ
plugin/storage/badger/spanstore/reader.go	`95.37% <0.00%> (-0.72%)`	⬇️
cmd/query/app/server.go	`97.08% <0.00%> (+1.45%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b51f68...f5582c5. Read the comment docs.

CHANGELOG.md

Signed-off-by: albertteoh <albert.teoh@logz.io>

albertteoh · 2021-02-23T05:02:21Z

CHANGELOG.md

 #### New Features

-* Add TLS Support for gRPC and HTTP endpoints of the Query server ([#2337](https://github.com/jaegertracing/jaeger/pull/2337), [#2772](https://github.com/jaegertracing/jaeger/pull/2772), [@rjs211](https://github.com/rjs211))
+* Add TLS Support for gRPC and HTTP endpoints of the Query and Collector servers ([#2337](https://github.com/jaegertracing/jaeger/pull/2337), [#2772](https://github.com/jaegertracing/jaeger/pull/2772), [#2798](https://github.com/jaegertracing/jaeger/pull/2798), [@rjs211](https://github.com/rjs211))


I've merged #2337, #2772 and #2798 together in this bullet given they're closely related and only differ by the backend component.

albertteoh · 2021-02-23T05:03:41Z

CHANGELOG.md

+#### Bug fixes, Minor Improvements
+
+* Use workaround for windows x509.SystemCertPool() ([#2756](https://github.com/jaegertracing/jaeger/pull/2756), [@Ashmita152](https://github.com/Ashmita152))
+* Guard against large string/binary allocations due to malformed sizes that lead to high memory utilization in jaeger-agent ([#2780](https://github.com/jaegertracing/jaeger/pull/2780), [@jpkrohling](https://github.com/jpkrohling))


Update description as requested; please advise if it could be better worded.

Guard against mal-formed payloads received by the agent, potentially causing high memory utilization.

jpkrohling

Reworded the Thrift issue a bit, but looks good to me!

jpkrohling · 2021-02-23T08:25:45Z

CHANGELOG.md

+#### Bug fixes, Minor Improvements
+
+* Use workaround for windows x509.SystemCertPool() ([#2756](https://github.com/jaegertracing/jaeger/pull/2756), [@Ashmita152](https://github.com/Ashmita152))
+* Guard against large string/binary allocations due to malformed sizes that lead to high memory utilization in jaeger-agent ([#2780](https://github.com/jaegertracing/jaeger/pull/2780), [@jpkrohling](https://github.com/jpkrohling))


Guard against mal-formed payloads received by the agent, potentially causing high memory utilization.

Signed-off-by: albertteoh <albert.teoh@logz.io>

Pull request has been modified.

jpkrohling · 2021-02-23T13:25:08Z

@albertteoh are you able to merge this, or should I?

albertteoh · 2021-02-23T21:30:25Z

@albertteoh are you able to merge this, or should I?

I can do the merge now, thanks for the review @yurishkuro @jpkrohling.

yurishkuro · 2021-02-24T00:02:20Z

First release via GitHub Actions: https://github.com/jaegertracing/jaeger/runs/1965285823

@Ashmita152 Great job upgrading the release process! It went flawlessly.

@albertteoh Congrats on the first release! :-)

Ashmita152 · 2021-02-24T02:52:29Z

Congrats @albertteoh Thank you @yurishkuro Those changes would be impossible without your constant help and guidance. I have two questions:

Do we need to do documentation release too to reflect the v1.22.0 ?
How should we update commands in documentation to let community know about our quay images ? Also, thinking about user experience, should we make quay as the default registry to pull from and dockerhub as secondary since quay doesn't have any limits. If we go with quay as default we might need to update references in all repositories where those images are referred.

yurishkuro · 2021-02-24T03:59:24Z

Yes, Albert and I are trying to get the docs release going, but it fails https://github.com/jaegertracing/documentation/runs/1966836829?check_suite_focus=true.

I have verified that the token for jaegertracingbot is valid by pushing a test commit, but the release failed because of checks on protected branch. Still investigating (cf. https://gitpro.ttaallkk.topmunity/t/how-to-push-to-protected-branches-in-a-github-action/16101/21)

yurishkuro · 2021-02-24T04:38:40Z

I did the release manually for now. Pretty weird, since it used to work previously when I tested the new GHA process.

yurishkuro · 2021-02-24T04:39:33Z

@Ashmita152 feel free to suggest edits to the docs regarding quay.

joe-elliott · 2021-02-24T13:21:38Z

I did 1.21.0 and don't recall any issues with docs release.

albertteoh · 2021-02-24T20:21:44Z

Since the 1.21 docs release, we introduced Github Actions for the release builds (sometime in December from memory) and I think this is the main reason for the recent release issues.

…

On Thu, Feb 25, 2021, 00:21 Joe Elliott ***@***.***> wrote: I did 1.21.0 and don't recall any issues with docs release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGK2LHS3QTU6VOKKW526EGLTAT4PDANCNFSM4YBXAJYQ> .

Preparing release v1.22.0

aaad661

Signed-off-by: albertteoh <albert.teoh@logz.io>

albertteoh requested a review from a team as a code owner February 23, 2021 03:50

albertteoh requested a review from pavolloffay February 23, 2021 03:50

yurishkuro reviewed Feb 23, 2021

View reviewed changes