Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v2 directory #2970

Merged
merged 2 commits into from
May 4, 2021
Merged

Remove v2 directory #2970

merged 2 commits into from
May 4, 2021

Conversation

f1r3starter
Copy link
Contributor

Signed-off-by: Andrii Filenko andrey.filenko.official@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Remove v2 directory
  • Update dependabot.yml

@f1r3starter f1r3starter requested a review from a team as a code owner April 30, 2021 09:09
@mergify mergify bot requested a review from jpkrohling April 30, 2021 09:10
jpkrohling
jpkrohling reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's an unrelated change to the jaeger-ui in it. Could you please revert it?

@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #2970 (7a45db3) into master (12bba8c) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   95.87%   95.98%   +0.11%     
==========================================
  Files         223      223              
  Lines        9718     9718              
==========================================
+ Hits         9317     9328      +11     
+ Misses        330      322       -8     
+ Partials       71       68       -3
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️
cmd/query/app/server.go 97.08% <0.00%> (+1.45%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+2.41%) ⬆️
cmd/collector/app/server/zipkin.go 76.92% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bba8c...7a45db3. Read the comment docs.

@jpkrohling
Copy link
Contributor

The CI seems to be failing because of the unrelated UI changes.

@f1r3starter
Copy link
Contributor Author

@jpkrohling Yeap, sorry for that, fixed

@f1r3starter f1r3starter force-pushed the remove_v2 branch 2 times, most recently from 8141963 to ef59462 Compare April 30, 2021 12:29
jpkrohling
jpkrohling previously approved these changes Apr 30, 2021
View reviewed changes
@jpkrohling
Copy link
Contributor

Could you please check the DCO failure?

Remove v2 directory
f76acb7 
Signed-off-by: Andrii Filenko <andrey.filenko@corp.kismia.com>
@mergify mergify bot dismissed jpkrohling’s stale review April 30, 2021 15:17

Pull request has been modified.

@f1r3starter
Copy link
Contributor Author

@jpkrohling Fixed, can you please trigger tests ?

@yurishkuro yurishkuro merged commit 87f1283 into jaegertracing:master May 4, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jpkrohling jpkrohling jpkrohling left review comments

@albertteoh albertteoh Awaiting requested review from albertteoh

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
Release 1.23.0
Development

Successfully merging this pull request may close these issues.

Remove v2 directory
3 participants
@f1r3starter @jpkrohling @yurishkuro