plugin/storage/badger/spanstore: use (TB).TempDir not hardcoded non-portable /mnt/* #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortable /mnt/* Previously the Benchmark code ALWAYS assumed that "/mnt/ssd/" would exist, yet when there is no permission or on read only systems, using it would fail. This change instead uses the benchmarks' temporary directory as the base for operations. Fixes jaegertracing#3301 Signed-off-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Codecov Report
@@ Coverage Diff @@
## master #3325 +/- ##
==========================================
+ Coverage 95.96% 95.99% +0.03%
==========================================
Files 259 259
Lines 15434 15434
==========================================
+ Hits 14811 14816 +5
+ Misses 527 525 -2
+ Partials 96 93 -3
Continue to review full report at Codecov.
|
albertteoh
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Benchmark code ALWAYS assumed that "/mnt/ssd/" would
exist, yet when there is no permission or on read only systems,
using it would fail. This change instead uses the benchmarks'
temporary directory as the base for operations.
Fixes #3301
Signed-off-by: Emmanuel T Odeke emmanuel@orijtech.com
Closes #3320
Rebased #3320 - the original PR wasn't passing DCO
Which problem is this PR solving?
Short description of the changes