Update Zipkin toDomain to handle 128bit traceId and ipv6 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
black-adder,
oibe,
vprithvi and
yurishkuro
as code owners
pavolloffay
force-pushed
the
zipkin-map-high-traceId-and-ipv6
branch
from
4d8392d
to
8a24026
Compare
pavolloffay
commented
Aug 16, 2017
| @@ -61,7 +61,7 @@ | |||
| } | |||
| }, | |||
| { | |||
| "traceID": "1", | |||
| "traceID": "20000000000000001", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
traceID: {"hi": 1, "lo": 2} did not worked
There was a problem hiding this comment.
checkout https://github.com/uber/jaeger/blob/5e5a361babba385bd0b9868bace1e10c75fc0829/model/span.go#L173 it overwrites the unmarshalling logic so that it can take a 128bit hex string and convert it into high and low
black-adder
changed the title
|
done in #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.