Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binaries for darwin/arm64 #3431

Merged

Conversation

jhchabran
Copy link
Contributor

@jhchabran jhchabran commented Dec 6, 2021

Signed-off-by: Jean-Hadrien Chabran jh@chabran.fr

Hello 👋 (reopening this with a proper feature branch)

Which problem is this PR solving?

I noticed that the release binaries do not include darwin/arm64, which is just about adding it to the build scripts.

Short description of the changes

I added a target in the Makefile and patched a few other scripts. You can see a successful binary build here https://github.com/jhchabran/jaeger/runs/4216116176?check_suite_focus=true and the release workflow uploads here: https://github.com/jhchabran/jaeger/releases/tag/v1.28.1

Please tell me if I have missed anything!

Signed-off-by: Jean-Hadrien Chabran <jh@chabran.fr>
@jhchabran jhchabran requested a review from a team as a code owner December 6, 2021 09:10
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #3431 (cd74a6f) into main (a64e82a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3431      +/-   ##
==========================================
+ Coverage   96.50%   96.52%   +0.01%     
==========================================
  Files         261      261              
  Lines       15277    15277              
==========================================
+ Hits        14743    14746       +3     
+ Misses        451      449       -2     
+ Partials       83       82       -1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64e82a...cd74a6f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants