Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing functions from xdg-go/scram pkg #3481

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

yurishkuro
Copy link
Member

Clean-up for #2046

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner January 17, 2022 05:06
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #3481 (4785764) into main (179073f) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3481      +/-   ##
==========================================
+ Coverage   96.44%   96.49%   +0.05%     
==========================================
  Files         262      262              
  Lines       15311    15311              
==========================================
+ Hits        14766    14774       +8     
+ Misses        460      454       -6     
+ Partials       85       83       -2     
Impacted Files Coverage Δ
cmd/query/app/server.go 95.58% <0.00%> (+1.47%) ⬆️
cmd/query/app/static_handler.go 95.80% <0.00%> (+1.79%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179073f...4785764. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge (squash) January 18, 2022 17:20
@yurishkuro yurishkuro merged commit cdcc272 into jaegertracing:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants