Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds due to upstream OTEL proto path change #3525

Merged
merged 3 commits into from
Feb 13, 2022

Conversation

albertteoh
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Addresses the build failure due to the package rename in open-telemetry/opentelemetry-proto@0e254b5.
  • Bumps the jaeger-idl submodule, make the corresponding go package path changes to seds, and make proto to update generated code.

Testing

make build-platform-binaries completes successfully.

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner February 13, 2022 00:30
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #3525 (311c851) into main (96026e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3525      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.01%     
==========================================
  Files         262      262              
  Lines       15337    15337              
==========================================
- Hits        14801    14800       -1     
  Misses        454      454              
- Partials       82       83       +1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96026e6...311c851. Read the comment docs.

@yurishkuro yurishkuro merged commit ed5fa99 into jaegertracing:main Feb 13, 2022
@albertteoh albertteoh deleted the update-idl-submodule branch February 13, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump the opentracing-proto submodule to fix go bindings
2 participants