Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ciphersuites in tls config #3564

Merged
merged 6 commits into from
Mar 6, 2022

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita ashmita.bohara@logz.io

Which problem is this PR solving?

Part of #3019

Short description of the changes

In golang's tls package, there are two kinds of ciphers: secure and insecure, we need to support both hence we are creating a map of all ciphers (mapping cipherName to cipherID)

I will raise min tls version support as separate pr.

Signed-off-by: Ashmita <ashmita.bohara@logz.io>
@Ashmita152 Ashmita152 requested a review from a team as a code owner March 5, 2022 02:13
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #3564 (0d30c76) into main (c156ebd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3564      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files         263      264       +1     
  Lines       15377    15402      +25     
==========================================
+ Hits        14838    14862      +24     
- Misses        456      457       +1     
  Partials       83       83              
Impacted Files Coverage Δ
pkg/config/tlscfg/ciphersuites.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/flags.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/options.go 100.00% <100.00%> (ø)
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c156ebd...0d30c76. Read the comment docs.

pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/options.go Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
@Ashmita152
Copy link
Contributor Author

👋 Hello Yuri

Thank you for the feedbacks. I tried to resolve them. It is ready for review again.

pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/flags.go Outdated Show resolved Hide resolved
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro merged commit df44af3 into jaegertracing:main Mar 6, 2022
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
* Add support for ciphersuites in tls config

Signed-off-by: Ashmita <ashmita.bohara@logz.io>

* Feedbacks

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>

* Feedbacks

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>

* Feedbacks

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants