Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string for go1.18 #3596

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 22, 2022

Fixing this error:

pkg/es/client/cluster_client.go:54:13: fmt.Errorf format %w has arg versionField of wrong type interface{}

cc @rubenvp8510

@bobrik bobrik requested a review from a team as a code owner March 22, 2022 23:21
@bobrik bobrik requested a review from pavolloffay March 22, 2022 23:21
Fixing this error:

```
pkg/es/client/cluster_client.go:54:13: fmt.Errorf format %w has arg versionField of wrong type interface{}
```

Signed-off-by: Ivan Babrou <github@ivan.computer>
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #3596 (6f37050) into main (f1ac025) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   96.54%   96.53%   -0.02%     
==========================================
  Files         264      264              
  Lines       15447    15447              
==========================================
- Hits        14914    14912       -2     
- Misses        449      451       +2     
  Partials       84       84              
Impacted Files Coverage Δ
pkg/es/client/cluster_client.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ac025...6f37050. Read the comment docs.

@yurishkuro yurishkuro enabled auto-merge (squash) March 23, 2022 01:25
@yurishkuro yurishkuro merged commit e08f5c0 into jaegertracing:main Mar 24, 2022
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Fixing this error:

```
pkg/es/client/cluster_client.go:54:13: fmt.Errorf format %w has arg versionField of wrong type interface{}
```

Signed-off-by: Ivan Babrou <github@ivan.computer>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants