Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Prometheus metrics implementation from jaeger-lib #3771

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 21, 2022

Follow-up to #3767:

  • copy prometheus package from jaeger-lib
  • refactor metrics builder
  • make JLibAdapter private to expvar module (to be migrated in the follow-up PRs)
  • add reverse adapter to jaeger-lib factory for use with jaeger-client-go (minimal dependency surface)

Partially addresses #3768

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 21, 2022 17:25
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3771 (c63da1a) into main (3d67ac8) will increase coverage by 0.00%.
The diff coverage is 99.31%.

@@           Coverage Diff            @@
##             main    #3771    +/-   ##
========================================
  Coverage   97.56%   97.57%            
========================================
  Files         282      287     +5     
  Lines       16426    16672   +246     
========================================
+ Hits        16026    16267   +241     
- Misses        317      321     +4     
- Partials       83       84     +1     
Impacted Files Coverage Δ
internal/metrics/expvar/factory.go 0.00% <0.00%> (ø)
cmd/flags/service.go 100.00% <100.00%> (ø)
internal/metrics/expvar/adapter.go 100.00% <100.00%> (ø)
internal/metrics/jlibadapter/adapter.go 100.00% <100.00%> (ø)
internal/metrics/metricsbuilder/builder.go 100.00% <100.00%> (ø)
internal/metrics/prometheus/cache.go 100.00% <100.00%> (ø)
internal/metrics/prometheus/factory.go 100.00% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 95.49% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d67ac8...c63da1a. Read the comment docs.

@yurishkuro yurishkuro merged commit 19e4544 into jaegertracing:main Jun 21, 2022
@yurishkuro yurishkuro deleted the add-prom branch June 21, 2022 17:48
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
…#3771)

Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant