Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdditionalDialOptions to ConnBuilder #3865

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

vprithvi
Copy link
Contributor

Signed-off-by: Prithvi Raj p.r@uber.com

Which problem is this PR solving?

Short description of the changes

  • Add additional grpc DialOptions, which allow for specifying custom interceptors/etc.

Signed-off-by: Prithvi Raj <p.r@uber.com>
@vprithvi vprithvi requested a review from a team as a code owner August 10, 2022 18:09
@yurishkuro yurishkuro enabled auto-merge (squash) August 10, 2022 18:16
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #3865 (af23ec1) into main (40e5a27) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3865      +/-   ##
==========================================
- Coverage   97.64%   97.63%   -0.02%     
==========================================
  Files         293      293              
  Lines       17062    17064       +2     
==========================================
  Hits        16660    16660              
- Misses        317      319       +2     
  Partials       85       85              
Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/builder.go 95.31% <100.00%> (+0.15%) ⬆️
pkg/config/tlscfg/cert_watcher.go 92.55% <0.00%> (-2.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yurishkuro yurishkuro merged commit 26e82f0 into jaegertracing:main Aug 10, 2022
@vprithvi vprithvi deleted the add-dialoptions branch December 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional grpc.DialOptions in agent reporter connection builder
2 participants