Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jaeger-agent sampling endpoint returns backwards incompatible JSON #3892

Closed
wants to merge 3 commits into from
Closed

fix: jaeger-agent sampling endpoint returns backwards incompatible JSON #3892

wants to merge 3 commits into from

Commits on Aug 31, 2022

  1. fix: jaeger-agent sampling endpoint perOperationStrategies returns … 

    …`[]`

- Returning an empty slice for `perOperationStrategies` instead of the default nil slice allows
  json.Marshal to marshal it to `[]` instead of `null`
- Fixes jaegertracing#3891

Signed-off-by: Prithvi Raj <p.r@uber.com>
    @vprithvi
    vprithvi committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b33a65c View commit details
    Browse the repository at this point in the history

  2. fmt 

    Signed-off-by: Prithvi Raj <p.r@uber.com>
    @vprithvi
    vprithvi committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4afd6d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. simplify 

    Signed-off-by: Prithvi Raj <p.r@uber.com>
    @vprithvi
    vprithvi committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    891291f View commit details
    Browse the repository at this point in the history