fix: jaeger-agent sampling endpoint returns backwards incompatible JSON #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`[]` - Returning an empty slice for `perOperationStrategies` instead of the default nil slice allows json.Marshal to marshal it to `[]` instead of `null` - Fixes jaegertracing#3891 Signed-off-by: Prithvi Raj <p.r@uber.com>
|
|
yurishkuro
approved these changes
Sep 1, 2022
Codecov ReportBase: 97.64% // Head: 97.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3897 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 293 293
Lines 17073 17075 +2
=======================================
+ Hits 16671 16673 +2
Misses 317 317
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perOperationStrategiesfield contains[]as a default value instead of nil. This was the behavior as of jaeger-agent v1.17 when using tchannel/thrift to communicate with collector.perOperationStrategiesinstead of the default nil slice allowsjson.Marshal to marshal it to
[]instead ofnullSigned-off-by: Prithvi Raj p.r@uber.com