Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global platform arg in cassandra schema dockerfile #4123

Merged

Conversation

jkandasa
Copy link
Member

Which problem is this PR solving?

  • Multi arch cassandra-schema container support is introduced in add multi arch support to cassandra-schema container #4122
  • for some reason BUILDPLATFORM argument is not loaded, hence linux/amd64 base image taken to all platforms containers, which leads the following error on non linux/amd64 systems.
standard_init_linux.go:228: exec user process caused: exec format error
  • To fix this issue, I removed the strict platform in base image of Dockerfile. Now the docker engine decide the base image architecture.

Short description of the changes

  • Removed --platform=${BUILDPLATFORM:-linux/amd64} from the base image.

Tested

  • Verified this change locally by running the following command under the directory plugin/storage/cassandra, result of the execution, I see actual platform images.
platforms="linux/amd64,linux/s390x,linux/ppc64le,linux/arm64"

docker buildx build --push \
  --progress=plain \
  --platform ${platforms} \
  --file ./Dockerfile \
  --tag quay.io/redhat-distributed-tracing-qe/jaeger-cassandra-schema:1.40.0 .
  • images are available in: quay.io/redhat-distributed-tracing-qe/jaeger-cassandra-schema:1.40.0

Document about platform argument on a base image

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
@jkandasa jkandasa requested a review from a team as a code owner December 22, 2022 16:13
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 97.16% // Head: 97.16% // No change to project coverage 👍

Coverage data is based on head (d25a5ba) compared to base (5f7865a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4123   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         295      295           
  Lines       17413    17413           
=======================================
  Hits        16920    16920           
  Misses        397      397           
  Partials       96       96           
Flag Coverage Δ
unittests 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 043d477 into jaegertracing:main Dec 22, 2022
@jkandasa jkandasa deleted the fix_cassandra_schema_multi_arch branch December 22, 2022 17:42
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Feb 22, 2023
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
…ing#4123)

Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
…ing#4123)

Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants