Use Protobuf-based JSON output for sampling strategies #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportBase: 97.10% // Head: 97.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4173 +/- ##
==========================================
+ Coverage 97.10% 97.12% +0.01%
==========================================
Files 296 297 +1
Lines 17501 17537 +36
==========================================
+ Hits 16995 17032 +37
+ Misses 407 406 -1
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
…#4173) ## Which problem is this PR solving? Related to open-telemetry/opentelemetry-specification#3126 ## Short description of the changes - changes the main `/sampling` endpoint to use Protobuf-based JSON marshaling instead of Thrift-based - adds unit tests to validate that the new endpoint is backwards compatible with Thrift-based serialization - opens the path to remove Thrift-based sampling data model throughout the codebase Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
…#4173) ## Which problem is this PR solving? Related to open-telemetry/opentelemetry-specification#3126 ## Short description of the changes - changes the main `/sampling` endpoint to use Protobuf-based JSON marshaling instead of Thrift-based - adds unit tests to validate that the new endpoint is backwards compatible with Thrift-based serialization - opens the path to remove Thrift-based sampling data model throughout the codebase Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Related to open-telemetry/opentelemetry-specification#3126
Short description of the changes
/samplingendpoint to use Protobuf-based JSON marshaling instead of Thrift-based