Support secure OTLP exporter config for hotrod

[graphaelli]

Which problem is this PR solving?

hotrod currently forces all connections to insecure in

jaeger/examples/hotrod/pkg/tracing/init.go

Line 85 in fedeb4c

otlptracehttp.WithInsecure(),

preventing SSL connections from succeeding. For example:

$ OTEL_EXPORTER_OTLP_ENDPOINT=https://hotrod.apm.us-east4.gcp.elastic-cloud.com:443 ./hotrod all -x otlp

2023/02/10 13:00:04 traces export: failed to send to http://hotrod.apm.us-east4.gcp.elastic-cloud.com:443/v1/traces: 400 Bad Request

Short description of the changes

• use secure connections when env var OTEL_EXPORTER_OTLP_ENDPOINT uses https scheme or OTEL_EXPORTER_OTLP_INSECURE=false

[yurishkuro]

except that now you broke the insecure mode, which is much more prevalent in demo setups

go run ./examples/hotrod all -x otlp

[graphaelli]

It doesn't break insecure mode, it changes the default on something user must opt into anyway. The original behavior is restored with:

OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 go run ./examples/hotrod all -x otlp

or

OTEL_EXPORTER_OTLP_INSECURE=true go run ./examples/hotrod all -x otlp

The goal is to make the following work, which I suspect is the most likely way folks engage with hotrod (that is, via docker images).

docker run -it --rm -v $PWD/ca-certificates.crt:/etc/ssl/certs/ca-certificates.crt -e OTEL_EXPORTER_OTLP_ENDPOINT=my-https-endpoint jaegertracing/example-hotrod:latest all -x otlp 

That said, if that's too big of an impact I'm fine to withdraw this.

[graphaelli]

I suppose we could just look for an https:// prefix on the env var and not add the option in that case?

[graphaelli]

Updated PR to use secure connections when env var OTEL_EXPORTER_OTLP_ENDPOINT uses https scheme or OTEL_EXPORTER_OTLP_INSECURE=false

[yurishkuro]

LGTM. Please make sure all commits are signed (or squash into one, usually easier to fix DCO this way)

[codecov]

Codecov Report

Base: 97.11% // Head: 97.10% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (527608b) compared to base (5b58370).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4231      +/-   ##
==========================================
- Coverage   97.11%   97.10%   -0.02%     
==========================================
  Files         302      302              
  Lines       17685    17685              
==========================================
- Hits        17175    17173       -2     
- Misses        411      412       +1     
- Partials       99      100       +1     

Flag	Coverage Δ
unittests	97.10% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugin/storage/badger/spanstore/reader.go	95.49% <0.00%> (-0.72%)	⬇️
plugin/storage/integration/integration.go	76.33% <0.00%> (+0.38%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.