Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP post port mapping to docker command #4406

Closed

Conversation

albertteoh
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • The HotRod example emits spans on jaeger-collector's HTTP endpoint.
  • This exposes the port being listened to for spans over the HTTP endpoint to fix an error in the HotRod example.
  • A minor typo is also fixed.

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner April 23, 2023 14:56
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6119406) 97.07% compared to head (550ac50) 97.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4406   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         300      300           
  Lines       17730    17730           
=======================================
+ Hits        17211    17212    +1     
+ Misses        417      416    -1     
  Partials      102      102           
Flag Coverage Δ
unittests 97.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@albertteoh
Copy link
Contributor Author

Closed in favour of #4407 because of the unintended jaeger-ui submodule modification.

@albertteoh albertteoh closed this Apr 23, 2023
@albertteoh albertteoh deleted the 4356-add-port-mapping branch April 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant