Rebuild jaeger-ui if the tree does not match any tag exactly #4553
Conversation
bobrik
force-pushed
the
ivan/rebuild-dirty
branch
from
f2c2731
to
28a499e
Compare
The previous behavior resulted in the prebuild upstream package being downloaded, even if the local tree has any changes, whether they are commited or not. This broke our internal build that has some patches applied. See: * jaegertracing#4251 (comment) Let's use a more strict approach and only use the prebuild package if the tag is exact and does not contain any extra changes. Signed-off-by: Ivan Babrou <github@ivan.computer>
bobrik
force-pushed
the
ivan/rebuild-dirty
branch
from
28a499e
to
2b8f725
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4553 +/- ##
==========================================
- Coverage 97.05% 97.04% -0.01%
==========================================
Files 301 301
Lines 17817 17817
==========================================
- Hits 17292 17291 -1
- Misses 421 422 +1
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bobrik could you elaborate a bit how your internal build is setup? Do you have a fork of both Jaeger and Jaeger-UI. |
|
Yes, we have patches for both |
|
I wonder if it makes more sense for you to have an option that can be passed to |
|
The only scenario where I can see it being useful is you want to rebuild with a changed environment (like node version), everything else should be covered by this change already. For this a bit more finessing might be required (I remember needing to nuke I can add |
…racing#4553) The previous behavior resulted in the prebuild upstream package being downloaded, even if the local tree has any changes, whether they are commited or not. This broke our internal build that has some patches applied. See: * jaegertracing#4251 (comment) Let's use a more strict approach and only use the prebuild package if the tag is exact and does not contain any extra changes. Signed-off-by: Ivan Babrou <github@ivan.computer> Signed-off-by: KevinSchneider <kevin.schneider@target.com>
…racing#4553) The previous behavior resulted in the prebuild upstream package being downloaded, even if the local tree has any changes, whether they are commited or not. This broke our internal build that has some patches applied. See: * jaegertracing#4251 (comment) Let's use a more strict approach and only use the prebuild package if the tag is exact and does not contain any extra changes. Signed-off-by: Ivan Babrou <github@ivan.computer> Signed-off-by: Afzal Ansari <afzal442@gmail.com>
The previous behavior resulted in the prebuild upstream package being downloaded, even if the local tree has any changes, whether they are commited or not. This broke our internal build that has some patches applied. See:
Let's use a more strict approach and only use the prebuild package if the tag is exact and does not contain any extra changes.