Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up after PR 4596 #4605

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Prevent potential future linter errors where errors are ignored

Short description of the changes

  • Handle error from Close

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de3cf99) 97.07% compared to head (56aa1b1) 97.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4605   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         301      301           
  Lines       17870    17870           
=======================================
  Hits        17347    17347           
  Misses        419      419           
  Partials      104      104           
Flag Coverage Δ
unittests 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit e0c83b0 into jaegertracing:main Jul 30, 2023
31 checks passed
@yurishkuro yurishkuro deleted the cleanup-es-otel branch July 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant