Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OTLP the default exporter in HotROD #4698

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

yurishkuro
Copy link
Member

Description of the changes

  • Make OTLP to be the default exporter of traces from HotROD
  • Update docker-compose file accordingly

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner August 24, 2023 15:37
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Make OTLP the default in HotROD Make OTLP the default exporter in HotROD Aug 24, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ae27a86) 97.04% compared to head (d2768f1) 97.04%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4698      +/-   ##
==========================================
- Coverage   97.04%   97.04%   -0.01%     
==========================================
  Files         301      301              
  Lines       17880    17880              
==========================================
- Hits        17352    17351       -1     
- Misses        423      424       +1     
  Partials      105      105              
Flag Coverage Δ
unittests 97.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit db3d1bb into jaegertracing:main Aug 24, 2023
31 checks passed
@yurishkuro yurishkuro deleted the fix-hotrod branch August 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant