Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up & fortify ci-release #4813

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Clean-up & fortify ci-release #4813

merged 1 commit into from
Oct 6, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • One of the previous runs of ci-release mistaken main tag as release version and pushed a release with this tag

Description of the changes

  • Add checks to the workflow to fail early of the latest git tag is not a semver
  • Speed-up Makefile by making ALL_SRCS and ALL_PKGS vars lazy-evaluated
  • Make semver check in scripts/package-deploy.sh more redable (perl instead of awk)

How was this change tested?

  • CI

@yurishkuro
Clean-up & fortify ci-release
c94c484 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 6, 2023 19:20
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 2389c6d into jaegertracing:main Oct 6, 2023
31 checks passed
@yurishkuro yurishkuro deleted the cleanup branch October 6, 2023 19:37
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro