Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #5368

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @jkowall. Please merge the Pull Request to incorporate the requested changes. Please tag @jkowall on your message if you have any questions related to the PR.

Security Fixes

Maintain Code Quality with Pre-Commit

Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@jkowall
Copy link
Contributor

jkowall commented Apr 17, 2024

I created this from the best practices related to fixing #5363

@jkowall jkowall added changelog:bugfix-or-minor-feature changelog:ci Change related to continuous integration / testing and removed changelog:bugfix-or-minor-feature labels Apr 17, 2024
@yurishkuro
Copy link
Member

I personally strongly dislike commit-hooks because they are very intrusive and disruptive of the flow. They are only tolerable if they are very fast, on the order of <2s, while most of the linters here are much slower. golint alone can take several minutes.

@jkowall
Copy link
Contributor

jkowall commented Apr 17, 2024

This was the suggestion per the security scorecard, I will look at another path. Thanks.

@jkowall jkowall closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants