Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace public InitFromOptions with private ConfigureFromOptions #5417

Merged
merged 3 commits into from
May 5, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 5, 2024

Which problem is this PR solving?

  • InitFromOptions was introduced 4yrs ago, but was not used by any code
  • Recently NewFactoryWithConfig constructors started using that function, but they only need private access

Description of the changes

  • Make function private
  • Rename to ConfigureWithOptions, since it does not initialize any connections, unlike Initialize().

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (4dc7708) to head (f70597f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5417      +/-   ##
==========================================
+ Coverage   94.60%   94.61%   +0.01%     
==========================================
  Files         346      346              
  Lines       16953    16951       -2     
==========================================
  Hits        16039    16039              
+ Misses        714      711       -3     
- Partials      200      201       +1     
Flag Coverage Δ
badger_v1 10.28% <0.00%> (+<0.01%) ⬆️
badger_v2 6.42% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v1 18.16% <10.52%> (+0.03%) ⬆️
cassandra-3.x-v2 6.14% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 18.16% <10.52%> (+0.03%) ⬆️
cassandra-4.x-v2 6.11% <0.00%> (+<0.01%) ⬆️
elasticsearch-5.x 5.74% <0.00%> (+0.01%) ⬆️
elasticsearch-6.x 5.74% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x 5.73% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x 5.73% <0.00%> (-0.01%) ⬇️
grpc_v1 12.59% <0.00%> (+<0.01%) ⬆️
grpc_v2 11.35% <0.00%> (-0.04%) ⬇️
kafka 9.99% <10.52%> (+0.03%) ⬆️
opensearch-1.x 5.73% <0.00%> (-0.01%) ⬇️
opensearch-2.x 5.74% <0.00%> (+<0.01%) ⬆️
unittests 91.44% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review May 5, 2024 19:14
@yurishkuro yurishkuro requested a review from a team as a code owner May 5, 2024 19:14
@yurishkuro yurishkuro enabled auto-merge (squash) May 5, 2024 21:14
@yurishkuro yurishkuro merged commit 4e81dbd into jaegertracing:main May 5, 2024
40 checks passed
@yurishkuro yurishkuro deleted the initFromOptions branch May 6, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants