Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Archive storage test for Cassandra #5420

Merged

Conversation

Wise-Wizard
Copy link
Contributor

Which problem is this PR solving?

This PR addresses the issue #5203

Description of the changes
This PR addresses the issue #5203 by integrating the testArchiveTrace function into the common Storage Integration type. Added the Archive Trace Test functionality to remaining Backends including Cassandra and Badger
How was this change tested?

The changes were tested by running the following command:

make test
bash scripts/cassandra-integration-test.sh

Checklist

  • I have read CONTRIBUTING_GUIDELINES.md
  • I have signed all commits
  • I have added unit tests for the new functionality
  • I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
@Wise-Wizard Wise-Wizard requested a review from a team as a code owner May 5, 2024 07:32
@Wise-Wizard Wise-Wizard requested a review from jkowall May 5, 2024 07:32
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (79d9729) to head (46e7de0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5420      +/-   ##
==========================================
+ Coverage   94.60%   94.66%   +0.05%     
==========================================
  Files         346      346              
  Lines       16951    16951              
==========================================
+ Hits        16037    16046       +9     
+ Misses        712      702      -10     
- Partials      202      203       +1     
Flag Coverage Δ
badger_v1 10.28% <ø> (ø)
badger_v2 6.36% <ø> (ø)
cassandra-3.x-v1 18.78% <ø> (+0.61%) ⬆️
cassandra-3.x-v2 6.14% <ø> (ø)
cassandra-4.x-v1 18.78% <ø> (+0.61%) ⬆️
cassandra-4.x-v2 6.14% <ø> (ø)
elasticsearch-5.x 5.73% <ø> (-0.02%) ⬇️
elasticsearch-6.x ?
elasticsearch-7.x 5.73% <ø> (-0.02%) ⬇️
elasticsearch-8.x 5.74% <ø> (+0.01%) ⬆️
grpc_v1 12.59% <ø> (ø)
kafka 9.99% <ø> (ø)
opensearch-1.x ?
opensearch-2.x ?
unittests 91.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label May 5, 2024
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
@Wise-Wizard
Copy link
Contributor Author

Can you please review it once? Initializing with f.Options.Get(archiveStorageConfig)
is showing an Error because in the below code snippet, nsCfg.Enabled is false, tried enabling it in it's declaration but still turned out to be false.
Screenshot 2024-05-05 205703

Wise-Wizard and others added 4 commits May 6, 2024 12:59
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
@Wise-Wizard
Copy link
Contributor Author

I also had a query regarding Badger, unlike other storages, it does not have the Archive Span Writer/Reader methods nor Options initialization of namespaces other than Primary. Is there some kind of documentation, I can refer to that will help me set up the Archive Trace method for Badger?

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

plugin/storage/integration/cassandra_test.go Outdated Show resolved Hide resolved
plugin/storage/integration/cassandra_test.go Outdated Show resolved Hide resolved
plugin/storage/cassandra/factory.go Outdated Show resolved Hide resolved
Wise-Wizard and others added 4 commits May 7, 2024 11:15
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yurishkuro yurishkuro changed the title Initialized Archive Reader/Writer for Cassandra Enable Archive storage test for Cassandra May 8, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) May 8, 2024 01:03
@yurishkuro yurishkuro merged commit b6c7242 into jaegertracing:main May 8, 2024
40 checks passed
@yurishkuro
Copy link
Member

Thanks!

@Wise-Wizard
Copy link
Contributor Author

Thanks!

No problem, actually I thought I could work on Badger as well in the same PR was going to do it after Cassandra was done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants