-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Archive storage test for Cassandra #5420
Enable Archive storage test for Cassandra #5420
Conversation
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5420 +/- ##
==========================================
+ Coverage 94.60% 94.66% +0.05%
==========================================
Files 346 346
Lines 16951 16951
==========================================
+ Hits 16037 16046 +9
+ Misses 712 702 -10
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
I also had a query regarding Badger, unlike other storages, it does not have the Archive Span Writer/Reader methods nor Options initialization of namespaces other than Primary. Is there some kind of documentation, I can refer to that will help me set up the Archive Trace method for Badger? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! |
No problem, actually I thought I could work on Badger as well in the same PR was going to do it after Cassandra was done? |
Which problem is this PR solving?
This PR addresses the issue #5203
Description of the changes
This PR addresses the issue #5203 by integrating the testArchiveTrace function into the common Storage Integration type. Added the Archive Trace Test functionality to remaining Backends including Cassandra and Badger
How was this change tested?
The changes were tested by running the following command:
make test
Checklist
for jaeger: make lint test
for jaeger-ui: yarn lint
andyarn test