-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set desired providers/converters instead of relying on defaults #5543
Set desired providers/converters instead of relying on defaults #5543
Conversation
Signed-off-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
e8b1820
to
daaad63
Compare
@@ -30,6 +37,20 @@ func Command() *cobra.Command { | |||
settings := otelcol.CollectorSettings{ | |||
BuildInfo: info, | |||
Factories: Components, | |||
ConfigProviderSettings: otelcol.ConfigProviderSettings{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why couldn't this be the default?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 327 327
Lines 16007 16021 +14
=======================================
+ Hits 15399 15413 +14
Misses 432 432
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks! |
Which problem is this PR solving?
Related to open-telemetry/opentelemetry-collector#10290
Description of the changes
Updates the
otelcol.CollectorSettings
passed tootelcol.NewCommand
to include desired providers and converters instead of relying onotelcol.NewCommand
to provide defaults.These providers/converters as the exact same being set by defaults here, which will probably stop getting set in the future.
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test