Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all mocks to mockery config file and regenerate #5626

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Jun 14, 2024

What problem is this solving

Resolves #5569

Description of the changes

  • added packages to mockery config file

How was this change tested?

  • make test

Checklist

Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner June 14, 2024 09:56
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (1c1bc08) to head (3cd8b4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5626      +/-   ##
==========================================
- Coverage   96.38%   95.52%   -0.86%     
==========================================
  Files         329      329              
  Lines       16060    16060              
==========================================
- Hits        15479    15341     -138     
- Misses        404      551     +147     
+ Partials      177      168       -9     
Flag Coverage Δ
badger_v1 8.04% <ø> (ø)
badger_v2 1.92% <ø> (ø)
cassandra-3.x-v1 16.60% <ø> (ø)
cassandra-3.x-v2 1.84% <ø> (ø)
cassandra-4.x-v1 16.60% <ø> (ø)
cassandra-4.x-v2 1.84% <ø> (ø)
elasticsearch-7.x-v1 18.87% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.08% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 19.08% <ø> (ø)
grpc_v1 9.46% <ø> (-0.02%) ⬇️
grpc_v2 7.49% <ø> (ø)
kafka ?
opensearch-1.x-v1 18.93% <ø> (ø)
opensearch-2.x-v1 18.93% <ø> (ø)
opensearch-2.x-v2 18.93% <ø> (+0.01%) ⬆️
unittests 94.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
@yurishkuro
Copy link
Member

Build is failing. Adding new packages is likely to cause changes to generated files, so you need to check them in too, and make sure that tests are green.

yurishkuro and others added 2 commits June 23, 2024 18:47
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title added packeges to mockery config file Add all mocks to mockery config file and regenerate Jun 24, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge (squash) June 24, 2024 03:04
@yurishkuro yurishkuro merged commit afdd311 into jaegertracing:main Jun 24, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create config for Mockery
2 participants