-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default configs for storage backends #5691
Support default configs for storage backends #5691
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5691 +/- ##
==========================================
+ Coverage 96.38% 96.40% +0.01%
==========================================
Files 334 334
Lines 16141 16144 +3
==========================================
+ Hits 15558 15563 +5
+ Misses 405 404 -1
+ Partials 178 177 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if _, ok := s.ext.factories[name]; ok { | ||
return fmt.Errorf("duplicate %s storage name %s", s.storageKind, name) | ||
func (s *storageExt) Start(_ context.Context, _ component.Host) error { | ||
mf := otelmetrics.NewFactory(s.telset.MeterProvider) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wise-Wizard using your new lib here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳🥳🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Which problem is this PR solving?
Description of the changes
backends
, which is a bit unfortunate, but the OTEL framework requires config to be a struct, it did not work with a map at the top level. Having a struct might actually be beneficial in the future if we need some top-level settingssome_store
andanother_store
in configs to emphasize that those are custom names, not part of the config structHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test