-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only attach :latest tag to versioned images from main #5781
Only attach :latest tag to versioned images from main #5781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
==========================================
+ Coverage 96.45% 96.66% +0.21%
==========================================
Files 342 342
Lines 16519 16519
==========================================
+ Hits 15933 15968 +35
+ Misses 395 362 -33
+ Partials 191 189 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
659bb43
to
73bdbcc
Compare
73bdbcc
to
51cfa7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## Which problem is this PR solving? - Resolves #5721 - The previous PR #5781 didn't quite work because we were still applying tags like `--tag docker.io/foo/bar` (without a version), which evidently leads Docker to treat them as `:latest`, which is exactly what we are trying to avoid for `main` branch ## Description of the changes - Remove usage of no-version tags `--tag docker.io/foo/bar` completely - Fix unit tests, make them stricter ## How was this change tested? - Unit tests Signed-off-by: Yuri Shkuro <github@ysh.us>
Which problem is this PR solving?
jaegertracing/all-in-one:latest
does not match the latest Docker versioned tag nor the latest git tag #5721Description of the changes
latest
tag when on themain
branchlatest
when on a semver tagHow was this change tested?