Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin codeql actions #5787

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Unpin codeql actions #5787

merged 1 commit into from
Jul 30, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 29, 2024 •
edited
Loading

Which problem is this PR solving?

  • Renovate bot does not upgrade these because the main branch there is on v2
  • Code scanning does not need to be locked down as strictly as reproducible builds

Description of the changes

  • Use v3 instead of exact commit or exact semver
  • The logs still show the exact version used, e.g. CODEQL_ACTION_VERSION: 3.25.15

How was this change tested?

  • CI

@yurishkuro
Unpin codeql actions
87338d4 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner July 29, 2024 22:02
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (81f81de) to head (87338d4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
+ Coverage   96.53%   96.65%   +0.12%     
==========================================
  Files         342      342              
  Lines       16519    16519              
==========================================
+ Hits        15946    15966      +20     
+ Misses        386      363      -23     
- Partials      187      190       +3
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (?)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.51% <ø> (-0.02%) ⬇️
grpc_v2 7.14% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.80% <ø> (-0.02%) ⬇️
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.80% <ø> (ø)
unittests 95.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkowall
jkowall approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit 12f8fbb into jaegertracing:main Jul 30, 2024
45 of 46 checks passed
@yurishkuro yurishkuro deleted the unpin-codeql branch July 30, 2024 14:51
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 1, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
41124e1 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 7, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
ab45d7f 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 8, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
c793999 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 13, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
469a707 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 14, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
e219d45 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
@yurishkuro @JaredTan95
Unpin codeql actions (jaegertracing#5787)
77bd36c 
## Which problem is this PR solving?
- Renovate bot does not upgrade these because the main branch there is
on v2
- Code scanning does not need to be locked down as strictly as
reproducible builds

## Description of the changes
- Use v3 instead of exact commit or exact semver
- The logs still show the exact version used, e.g.
`CODEQL_ACTION_VERSION: 3.25.15`

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall jkowall approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @jkowall