Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Upgrade to otel-collector v0.111.0 and fix breaking changes #6053

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

mahadzaryab1
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • The following breaking changes from otel-collector v0.111.0 were addressed in this PR
    • exporterhelper.TimeoutSettings was deprecated in favour of exporterhelper.TimeoutConfig
    • ClientConfig.ToClientConnWithOptions was deprecated in favour of ClientConfig.ToClientConn
    • CreateTracesReceiver was deprecated in favour of CreateTraces
    • ServerConfig.ToServerWithOptions was deprecated in favour ServerConfig.ToServer

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review October 4, 2024 23:15
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 4, 2024 23:15
@dosubot dosubot bot added the area/otel label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (fa31b89) to head (c3afa18).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ger/internal/extension/remotesampling/extension.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6053   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files         349      349           
  Lines       16587    16587           
=======================================
  Hits        16074    16074           
  Misses        329      329           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.00% <0.00%> (ø)
badger_v2 1.82% <0.00%> (ø)
cassandra-4.x-v1 15.77% <0.00%> (ø)
cassandra-4.x-v2 1.74% <0.00%> (ø)
cassandra-5.x-v1 15.77% <0.00%> (ø)
cassandra-5.x-v2 1.74% <0.00%> (ø)
elasticsearch-6.x-v1 18.71% <0.00%> (ø)
elasticsearch-7.x-v1 18.77% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 18.97% <0.00%> (ø)
elasticsearch-8.x-v2 1.82% <0.00%> (+0.01%) ⬆️
grpc_v1 9.38% <66.66%> (ø)
grpc_v2 7.13% <0.00%> (+0.01%) ⬆️
kafka-v1 9.71% <0.00%> (ø)
kafka-v2 1.82% <0.00%> (ø)
memory_v2 1.82% <0.00%> (ø)
opensearch-1.x-v1 18.83% <0.00%> (+0.01%) ⬆️
opensearch-2.x-v1 18.81% <0.00%> (ø)
opensearch-2.x-v2 1.82% <0.00%> (+0.01%) ⬆️
tailsampling-processor 0.46% <0.00%> (ø)
unittests 95.70% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Oct 5, 2024
@yurishkuro yurishkuro changed the title [fix] Upgrade to otel-collector v0.111.0 and Fix Breaking Changes [fix] Upgrade to otel-collector v0.111.0 and fix breaking changes Oct 5, 2024
@yurishkuro yurishkuro merged commit 47d1e8d into jaegertracing:main Oct 5, 2024
48 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address breaking changes in OTEL v0.111.0
2 participants