Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HotROD Docker command #949

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Fix HotROD Docker command #949

merged 1 commit into from
Jul 23, 2018

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

  • The HotROD Docker example is missing the all command

Short description of the changes

  • Added the all command
  • Split the command into more readable lines
  • Fixed versions to 1.6
  • Changed the Jaeger command to run in the foreground

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #949 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #949   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         136    136           
  Lines        6322   6322           
=====================================
  Hits         6322   6322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933efb3...754e775. Read the comment docs.

--rm \
--link jaeger \
-p8080-8083:8080-8083 \
jaegertracing/example-hotrod:1.6 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we need to remember to update this every time we do a major release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or add a note before that asking the reader to verify what's the latest version. The alternative is to keep using "latest" and trust that the "latest" build on Docker Hub is compatible with the command (latest == latest build, not latest version)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest == latest build, not latest version I think this is the problem, should we call the latest build master instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but do we want to point users to use the tip of the branch, instead of a released version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the fixed version. We can add a link to docker hub and a note for people to check for latest version.

@yurishkuro
Copy link
Member

The problem with latest is that Docker may not re-resolve if if the user already run latest previously when it was pointing to a different image / version.

@yurishkuro yurishkuro merged commit fe43631 into jaegertracing:master Jul 23, 2018
@ghost ghost removed the review label Jul 23, 2018
@jpkrohling jpkrohling deleted the Fix-HotRod-Docker-Command branch July 28, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants