-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HotROD Docker command #949
Fix HotROD Docker command #949
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 136 136
Lines 6322 6322
=====================================
Hits 6322 6322 Continue to review full report at Codecov.
|
--rm \ | ||
--link jaeger \ | ||
-p8080-8083:8080-8083 \ | ||
jaegertracing/example-hotrod:1.6 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we need to remember to update this every time we do a major release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or add a note before that asking the reader to verify what's the latest version. The alternative is to keep using "latest" and trust that the "latest" build on Docker Hub is compatible with the command (latest == latest build, not latest version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest == latest build, not latest version
I think this is the problem, should we call the latest build master
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but do we want to point users to use the tip of the branch, instead of a released version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the fixed version. We can add a link to docker hub and a note for people to check for latest version.
The problem with |
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
all
commandShort description of the changes
all
command