-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin proto / gogo versions for repeatable builds #984
Conversation
https://travis-ci.org/jaegertracing/jaeger/jobs/415593435 failed with
@davit-y @vprithvi do you think it's protobuf-related or just an unstable test? |
Signed-off-by: Yuri Shkuro <ys@uber.com>
2f09812
to
a2d2ece
Compare
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 139 139
Lines 6400 6400
=====================================
Hits 6400 6400 Continue to review full report at Codecov.
|
I think this test is unstable, I was able to get it to fail locally without the protobuf changes. |
a2d2ece
to
e889314
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
Undo some upgrades introduced in #940. A short term fix to #985.