Updated the XML Schemas for Jakarta EE 9 versions of the specification #8

ivannov · 2020-04-16T19:33:20Z

Signed-off-by: Ivan St. Ivanov ivan.st.ivanov@gmail.com

Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm

The permissions_7.xsds version needs to be bumped since the namespace is changed. This file has not changed since Java EE 7. My suggestion would be to bump it to 9 to match the current release.

Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm

Looks good to me.

hussainnm

There are a lot of test errors, can you check by running

ant clean build test

I have the fix in my repository
3f83473

bshannon

If the tests are failing that means they need to be updated as well.

jakartaee9/src/web-facelettaglibrary_3_0.xsds

jakartaee9/src/web-facesconfig_3_0.xsds

bshannon · 2020-04-18T00:52:08Z

jakartaee9/src/web-partialresponse_3_0.xsds

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--

-    Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+    Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.


You know what I'm going to say, right? :-)
Please check all files to make sure the first copyright date has not been lost.

jakartaee9/src/connectors_2_0.xsds

…a name Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm

There are few more places you would need to replace JSF, JAX-WS, JAX-RPC, JMS and JTA

Namespace references need to change from javax to jakarta. I do not see any test to validate such a change.

Any reference to specification section numbers should match with current document.

hussainnm · 2020-04-18T07:49:57Z

jakartaee9/src/connector_2_0.xsds

 	      ...
 	    </connector>

 	The instance documents may indicate the published version of
 	the schema using the xsi:schemaLocation attribute for Jakarta EE
 	namespace with the following location:

-	https://jakarta.ee/xml/ns/jakartaee/connector_1_7.xsd
+	https://jakarta.ee/xml/ns/jakartaee/connectors_2_0.xsd


Suggested change

https://jakarta.ee/xml/ns/jakartaee/connectors_2_0.xsd

https://jakarta.ee/xml/ns/jakartaee/connector_2_0.xsd

hussainnm · 2020-04-18T07:50:18Z

jakartaee9/src/connector_2_0.xsds

@@ -49,16 +49,16 @@
 	    <connector xmlns="https://jakarta.ee/xml/ns/jakartaee"
 	      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 	      xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee
-		 https://jakarta.ee/xml/ns/jakartaee/connector_1_7.xsd"
-	      version="1.7">
+		 https://jakarta.ee/xml/ns/jakartaee/connectors_2_0.xsd"


Suggested change

https://jakarta.ee/xml/ns/jakartaee/connectors_2_0.xsd"

https://jakarta.ee/xml/ns/jakartaee/connector_2_0.xsd"

hussainnm · 2020-04-18T07:51:23Z

jakartaee9/src/web-facelettaglibrary_3_0.xsds


-      <p>JSF 2.3 Facelet Tag Libraries that wish to conform to this
+      <p>JSF 3.0 Facelet Tag Libraries that wish to conform to this


JSF to Jakarta Server Faces

ivannov · 2020-04-19T11:09:44Z

@hussainnm thanks for your reviews and the help!

I just didn't understand this:

Namespace references need to change from javax to jakarta. I do not see any test to validate such a change.

Which namespaces do you mean? I see some javax packages in the documentation mainly

hussainnm · 2020-04-19T12:08:54Z

Yes, I meant the ones in documentation and CDATA.

https://github.com/eclipse-ee4j/jakartaee-schemas/blob/6e7850c633f7b2d3e18898367c1d47527d3e6b5e/jakartaee9/src/jakartaee_9.xsds#L1349-L1359

In the above example, it mentions the permitted values are javax.jms.ConnectionFactory. This should be changed to jakarta.jms.ConnectionFactory.

hussainnm

I have flagged few places where rework is required. The full spec name with Jakarta is needed only if it is directly referring to a spec. In most cases the short name of the spec will do.

Revert the changes made to ejb-jar_4_0.xsds. This file is already reviewed and approved.
JAX-WS is Jakarta XML Web Services, Jakarta Enterprise Web Services is new name for Web Services for Java EE.
@arjantijms can you please review the JSF changes.

Someone needs to review the Connectors changes as well.

jakartaee9/src/application-client_9.xsds

-	client deployment descriptor describes the EJB components
-	and external resources referenced by the application
-	client.
+	client deployment descriptor describes the Jakarta Enterprise 


hussainnm · 2020-04-19T16:28:41Z

jakartaee9/src/application-client_9.xsds

-	  The ejb-ref-name element contains the name of an EJB
-	  reference. The EJB reference is an entry in the application
-	  client's environment and is relative to the
+	  The ejb-ref-name element contains the name of an Jakarta Enterprise 


Change this to enterprise bean reference

hussainnm · 2020-04-19T16:29:03Z

jakartaee9/src/application-client_9.xsds

-	  reference. The EJB reference is an entry in the application
-	  client's environment and is relative to the
+	  The ejb-ref-name element contains the name of an Jakarta Enterprise 
+	  Beans reference. The Jakarta Enterprise Beans reference is an entry 


Change this to enterprise bean reference

hussainnm · 2020-04-19T16:29:44Z

jakartaee9/src/connector_2_0.xsds

@@ -35,9 +35,9 @@
    <xsd:documentation>
      <![CDATA[

-	This is the XML Schema for the Connector 1.7 deployment
+	This is the XML Schema for the Jakarta Connectors 2.0 deployment


Drop Jakarta in this context.

hussainnm · 2020-04-19T16:38:18Z

jakartaee9/src/connector_2_0.xsds

 	descriptor.  The deployment descriptor must be named
-	"META-INF/ra.xml" in the connector's rar file.  All Connector
+	"META-INF/ra.xml" in the connector's rar file.  All Jakarta Connectors


Drop Jakarta in this context.

"All Connector deployment descriptors" sounds right than "All Connectors deployment descriptors".

I will let others comment on this.

hussainnm · 2020-04-19T17:13:19Z

jakartaee9/src/web-app_5_0.xsds

-          java:comp/env context.  The name must be unique within
-          the web application.
+          The ejb-ref-name element contains the name of an Jakarta 
+          Enterprise Beans reference. The Jakarta Enterprise Beans 


Suggested change

Enterprise Beans reference. The Jakarta Enterprise Beans

enterprise bean reference. The enterprise bean

hussainnm · 2020-04-19T17:16:15Z

jakartaee9/src/web-facelettaglibrary_3_0.xsds


-      <p>JSF 2.3 Facelet Tag Libraries that wish to conform to this
-      schema must declare it in the following manner.</p>
+      <p>Jakarta Server faces 3.0 Facelet Tag Libraries that wish to conform to 


Suggested change

<p>Jakarta Server faces 3.0 Facelet Tag Libraries that wish to conform to

<p>Jakarta Server Faces 3.0 Facelet Tag Libraries that wish to conform to

In this file references to JSF could be shortened to just Faces instead of Jakarta Server Faces. e.g., Faces Behavior, Faces UIComponent, Faces Converter, Faces Validator.
I will let others comment on this. (@arjantijms)

hussainnm · 2020-04-19T17:22:51Z

jakartaee9/src/web-fragment_5_0.xsds

@@ -35,7 +35,7 @@
    <xsd:documentation>
      <![CDATA[

-        This is the XML Schema for the Servlet 4.0 deployment descriptor.
+        This is the XML Schema for the Jakarta Servlet 5.0 deployment descriptor.


Drop Jakarta in this context

jakartaee9/src/web-fragment_5_0.xsds

* New specification names in schema docs * Updated namespaces from javax to jakarta Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

…documentation Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm

All changes look good.

Only two open comments in connector_2_0.xsd which others need to comment on:
https://github.com/eclipse-ee4j/jakartaee-schemas/blob/c24b377c0755f13d2e0fecad8060cf73777b5d2a/jakartaee9/src/connector_2_0.xsds#L269
Architecture was dropped from the spec name. Jakarta Connectors specification should be fine.
https://github.com/eclipse-ee4j/jakartaee-schemas/blob/c24b377c0755f13d2e0fecad8060cf73777b5d2a/jakartaee9/src/connector_2_0.xsds#L953
Jakarta Transactions transactions

Updated the XML Schemas for Jakarta EE 9 versions of the specification

614aa3d

Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

ivannov force-pushed the schemas-to-jee9 branch from ec7ee07 to 614aa3d Compare April 16, 2020 20:11

hussainnm reviewed Apr 17, 2020

View reviewed changes

Bump the version of permission to 9

b4a268a

Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm approved these changes Apr 17, 2020

View reviewed changes

hussainnm suggested changes Apr 17, 2020

View reviewed changes

bshannon suggested changes Apr 18, 2020

View reviewed changes

Fixed tests, copyright year of some schemas and Connectors spec schem…

0fe1051

…a name Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

hussainnm suggested changes Apr 18, 2020

View reviewed changes

hussainnm reviewed Apr 19, 2020

View reviewed changes

ivannov added 2 commits April 20, 2020 10:48

Some more migrations to JEE 9:

499a21d

* New specification names in schema docs * Updated namespaces from javax to jakarta Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

Distinguish between specification name and terminology in the schema …

c24b377

…documentation Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>

ivannov force-pushed the schemas-to-jee9 branch from a6437ef to c24b377 Compare April 20, 2020 07:49

hussainnm reviewed Apr 20, 2020

View reviewed changes

ivargrimstad self-requested a review April 28, 2020 16:45

ivargrimstad approved these changes Apr 28, 2020

View reviewed changes

ivargrimstad merged commit 11a456e into jakartaee:master Apr 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated the XML Schemas for Jakarta EE 9 versions of the specification #8

Updated the XML Schemas for Jakarta EE 9 versions of the specification #8

ivannov commented Apr 16, 2020

hussainnm left a comment

hussainnm left a comment

hussainnm left a comment •

edited

Loading

bshannon left a comment

bshannon Apr 18, 2020

hussainnm left a comment •

edited

Loading

hussainnm Apr 18, 2020

hussainnm Apr 18, 2020

hussainnm Apr 18, 2020

ivannov commented Apr 19, 2020

hussainnm commented Apr 19, 2020

hussainnm left a comment

This comment was marked as resolved.

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm Apr 19, 2020

hussainnm left a comment •

edited

Loading

	https://jakarta.ee/xml/ns/jakartaee/connectors_2_0.xsd
	https://jakarta.ee/xml/ns/jakartaee/connector_2_0.xsd


		<p>JSF 2.3 Facelet Tag Libraries that wish to conform to this
		<p>JSF 3.0 Facelet Tag Libraries that wish to conform to this

	Enterprise Beans reference. The Jakarta Enterprise Beans
	enterprise bean reference. The enterprise bean

	<p>Jakarta Server faces 3.0 Facelet Tag Libraries that wish to conform to
	<p>Jakarta Server Faces 3.0 Facelet Tag Libraries that wish to conform to

Updated the XML Schemas for Jakarta EE 9 versions of the specification #8

Updated the XML Schemas for Jakarta EE 9 versions of the specification #8

Conversation

ivannov commented Apr 16, 2020

hussainnm left a comment

Choose a reason for hiding this comment

hussainnm left a comment

Choose a reason for hiding this comment

hussainnm left a comment • edited Loading

Choose a reason for hiding this comment

bshannon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hussainnm left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivannov commented Apr 19, 2020

hussainnm commented Apr 19, 2020

hussainnm left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hussainnm left a comment • edited Loading

Choose a reason for hiding this comment

hussainnm left a comment •

edited

Loading

hussainnm left a comment •

edited

Loading

hussainnm left a comment •

edited

Loading