eclipse-ee4j#212 - Remove Jakarta Management #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RohitKumarJain <rohit.ku.jain@oracle.com>
alwin-joseph
changed the title
|
I think you need changes in below files too. You can look for 'javaeemgmt' , 'j2eetools/mgmt' 'j2eetools-mgt'. Remove javax.management.j2ee-api.jar Thanks to Scott's PR #292 , which can be referred for this. |
|
Thank you @alwin-joseph , I'll look into this. |
Signed-off-by: RohitKumarJain <rohit.ku.jain@oracle.com>
|
Should we also remove install/j2eemgmt/docs/J2EEMGMTJavaDocAssertions.html? |
gurunrao
approved these changes
Jun 9, 2020
Signed-off-by: RohitKumarJain <rohit.ku.jain@oracle.com>
Thanks @scottmarlow , I have addressed your comment. |
|
Closing it because it is not allowing to resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RohitKumarJain rohit.ku.jain@oracle.com