Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet api issue 175 add cookie set attribute v3 #401

Merged
merged 15 commits into from
May 17, 2021
Merged

Servlet api issue 175 add cookie set attribute v3 #401

merged 15 commits into from
May 17, 2021

Commits on Apr 26, 2021

  1. Add Cookie#setAttribute 

    jakartaee#175
jakartaee#271
    @BalusC
    BalusC committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    5bb8145 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of git@github.com:BalusC/servlet-api.git

    @BalusC
    BalusC committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    6efffc6 View commit details
    Browse the repository at this point in the history

  3. Skip null value from check for reserved token

    @BalusC
    BalusC committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    5fb98a5 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2021

  1. Alternative approach to cookie attribute handling 

    github.com/jakartaee/pull/399#discussion_r624276777
    @BalusC
    BalusC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    3493d02 View commit details
    Browse the repository at this point in the history

  2. Make sure path is referenced via constant

    @BalusC
    BalusC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    d5ec45f View commit details
    Browse the repository at this point in the history

  3. In hindsight, token check doesn't need to be performed on value

    @BalusC
    BalusC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    5d98584 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/servlet-api-issue-175_add-cookie… 

    …-setAttribute' into servlet-api-issue-175_add-cookie-setAttribute-v2
    @BalusC
    BalusC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    bda9697 View commit details
    Browse the repository at this point in the history

  5. Match casing with spec; mapping is case insensitive anyway

    @BalusC
    BalusC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    0c58ccd View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Optimized Cookie to lazily create attribute map

    @gregw
    gregw committed May 3, 2021
    Configuration menu
    Copy the full SHA
    597c87c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Added junit test

    @gregw
    gregw committed May 4, 2021
    Configuration menu
    Copy the full SHA
    6201792 View commit details
    Browse the repository at this point in the history

  2. Updates from review

    @gregw
    gregw committed May 4, 2021
    Configuration menu
    Copy the full SHA
    5754e4e View commit details
    Browse the repository at this point in the history

  3. Fixed quote

    @gregw
    gregw committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f407bb4 View commit details
    Browse the repository at this point in the history

  4. surefire plugin

    @gregw
    gregw committed May 4, 2021
    Configuration menu
    Copy the full SHA
    9e58b99 View commit details
    Browse the repository at this point in the history

  5. Updates from review

    @gregw
    gregw committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2a80335 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Updates from review

    @gregw
    gregw committed May 5, 2021
    Configuration menu
    Copy the full SHA
    187cc61 View commit details
    Browse the repository at this point in the history