-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up TCK release notes for Jakarta Standard Tag Library #132
Comments
The current set of docs have made the corrections for Jakarta EE9. All we need to do for this issue is ensure that the index and ReleaseNotes are property updated for Jakarta EE10: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/install/jstl/docs |
@scottmarlow is it the Jakarta Tags team responsibility to update these in the TCK or does the TCK project team take care of this? |
@pnicolucci it doesn't matter much to me as to whom makes the changes as long as they are complete before Jakarta Tags is released as final (as we cannot make further Tags TCK changes to doc after that). I would be happy with doc changes from any contributor, regardless of whether they are committors on Jakarta Tags or Platform TCK projects. FYI the previous update for EE 9.1 was via jakartaee/platform-tck@3b179ec#diff-9a5de9445b8718b8b26ab9e7ff3ac55a3d4a71ec3ccd88b0576d864a028ec33d |
@pnicolucci I'm giving the update a shot. I'll create a draft pr with the results. Do you plan to run the Tags TCK yourself? Or will someone else run that? I would like to ask which operating system will be used for the testing. The current Tags TCK release notes includes:
I will need to know what to change ^ to. For reference, I just installed CC @edbratt |
Hey @scottmarlow , what are our options for running the TCK. I believe For the platforms do we just need to list whatever platform is actually used when the tests are executed? If that's the case I believe previously for Tags 2.0 we used Glassfish as the compatible implemented so my plan would be to do the same this go around for Tags 3.0. |
https://jakarta.ee/specifications/tags/2.0/ shows that https://github.com/eclipse-ee4j/glassfish/releases/download/6.0.0-M3-2020-10-04/glassfish-6.0.0-M3-2020-10-04.zip was used for verifying Tags 2.0. I imagine that the first available Tags 3.0 implementation could be used to validate the Tags 3.0 release. As to the how or who can run that, IMO, whomever that is, they need to push the TCK results to a publicly available location and identify the publicly available Tags implementation (and version) and include the implementation download link (as per https://jakarta.ee/committees/specification/tckprocess/). As you proceed through the Tags ballot process, ^ is good to discuss with your mentor as well.
Makes sense.
I think that would need to be a milestone release build of the Tags 3.0 compatible implementation, GlassFish 7.0 seems like a fine choice but it really could be any (open source) Tags 3.0 compatible implementation that is publicly available in a milestone release form. |
The issues in the original email thread were addressed by Scott's PR. I'll close this issue, but open a new issue about running the TCK on Glassfish once we have a milestone/RC release. |
See discussion here :https://www.eclipse.org/lists/jakarta.ee-spec/msg01206.html
The text was updated successfully, but these errors were encountered: