Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run EE10 TCK and Publish Results #219

Closed
volosied opened this issue Feb 23, 2022 · 3 comments
Closed

Run EE10 TCK and Publish Results #219

volosied opened this issue Feb 23, 2022 · 3 comments

Comments

@volosied
Copy link
Contributor

volosied commented Feb 23, 2022

Once we have a finalized release, we need to run the TCK and publish the results. Suggestion below recommends using GlassFish 7.0 for the build.


Hey @scottmarlow , what are our options for running the TCK. I believe @arjantijms did this in the past for this project. @arjantijms any input here?

https://jakarta.ee/specifications/tags/2.0/ shows that https://github.com/eclipse-ee4j/glassfish/releases/download/6.0.0-M3-2020-10-04/glassfish-6.0.0-M3-2020-10-04.zip was used for verifying Tags 2.0. I imagine that the first available Tags 3.0 implementation could be used to validate the Tags 3.0 release. As to the how or who can run that, IMO, whomever that is, they need to push the TCK results to a publicly available location and identify the publicly available Tags implementation (and version) and include the implementation download link (as per https://jakarta.ee/committees/specification/tckprocess/).

As you proceed through the Tags ballot process, ^ is good to discuss with your mentor as well.

For the platforms do we just need to list whatever platform is actually used when the tests are executed? If that's the case then it just depends on who executes the TCK once we have something available for testing.

Makes sense.

I believe previously for Tags 2.0 we used Glassfish as the compatible implemented so my plan would be to do the same this go around for Tags 3.0.

I think that would need to be a milestone release build of the Tags 3.0 compatible implementation, GlassFish 7.0 seems like a fine choice but it really could be any (open source) Tags 3.0 compatible implementation that is publicly available in a milestone release form.

Originally posted by @scottmarlow in #132 (comment)

@volosied volosied changed the title Run TCK and Pubish Results Run EE10 TCK and Publish Results Feb 23, 2022
@volosied
Copy link
Contributor Author

volosied commented Mar 7, 2022

@scottmarlow

Can we have a TCK run for Tags now that the Jakarta Tags 3.0.0 api/impl has been staged? I saw that there were a few failures in the last run for JDK 17 (but they looked related to JSP/EL). I didn't get a chance to view the JDK 11 logs.

Glasshfish was updated here: eclipse-ee4j/glassfish#23847 (comment)

Thanks

@scottmarlow
Copy link

@volosied https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/75 is running now with JDK 11 + https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/76 is running with JDK 17

FYI, the Jakarta Tags 3.0 TCK User Guide doesn't appear to be updated yet as it still references 2.0

@volosied
Copy link
Contributor Author

Thanks for the reminder -- I've created PR jakartaee/platform-tck#886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants