Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSTL TCK User Guide for Tags 3.0 #886

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

volosied
Copy link
Contributor

@volosied volosied commented Mar 10, 2022

~ Ready for Review ~

  • Updated attributes to reference Tags version 3.0 and Glassfish 7.0
  • Updated dates & references to EE 10.
  • Removed COMPAT documentation as that's no longer needed (since the tests were updated to use the default Java 11 locales. See 30 standalone tags (jstl) failures #631 (comment))

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow

@scottmarlow
Copy link
Contributor

Should also update the user_guides/jstl/src/main/jbake/content/install-server.inc which also still references EE 8 and is included from install.adoc. The same for rebuild.inc in the same folder.

@volosied
Copy link
Contributor Author

Thanks for spotting that. I updated all EE 8 references to EE 10 in these 3 files.

    modified:   src/main/jbake/content/config.inc
    modified:   src/main/jbake/content/install-server.inc
    modified:   src/main/jbake/content/rebuild.inc

@scottmarlow
Copy link
Contributor

@volosied please let us know when you are done making changes so that we can do another review. Thanks!

@volosied
Copy link
Contributor Author

@scottmarlow Sure, let me take a look at this again.

One question, should I specify only JDK 11 or should JDK 17 also be mention for the Java SEversion? I saw the TCK is run for both versions.

@scottmarlow
Copy link
Contributor

@volosied Please do mention both JDK 11 and JDK 17 as the EE 10 release plan calls for both to be supported:

TCK Source Level

The TCKs will be compiled at the Java SE 11 level. In order to allow for runtimes beyond Java SE 11, the TCK will also need to be (successfully) executed with Java SE 17.

@volosied
Copy link
Contributor Author

Section 4.1 Step 2 says:
Copy <TS_HOME>/bin/ts.jte.jdk11 as <TS_HOME>/bin/ts.jte if JAVA_HOME is Java SE 11. Edit your <TS_HOME>/bin/ts.jte file and set the following environment variables:

Should this be removed/edited since java 11 is the minimum for the TCK now?

@scottmarlow
Copy link
Contributor

Section 4.1 Step 2 says: Copy <TS_HOME>/bin/ts.jte.jdk11 as <TS_HOME>/bin/ts.jte if JAVA_HOME is Java SE 11. Edit your <TS_HOME>/bin/ts.jte file and set the following environment variables:

Should this be removed/edited since java 11 is the minimum for the TCK now?

Removing sounds right as the ts.jte.jdk11 file was already merged with ts.jte in https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jstl/bin/ts.jte

@volosied
Copy link
Contributor Author

@pnicolucci @arjantijms Let me know if this looks good (or if any more changes are needed). Thanks

@scottmarlow
Copy link
Contributor

@volosied can this pull request be updated to be ready for review since there are no further changes expected to the User Guide for Tags 3.0?

@volosied volosied marked this pull request as ready for review April 11, 2022 19:00
@volosied
Copy link
Contributor Author

@volosied I believe you're right -- I marked it as ready for review. Thank you.

:CopyrightDates: 2017, 2021
:TechnologyRI: Eclipse GlassFish 6.1
:TechnologyVersion: 3.0
:ReleaseDate: March 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update to April

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to May instead as that month is more likely at this point.

@@ -23,7 +23,7 @@ published in a Java SE environment are located under
`$TS_HOME/classes`.

The {TechnologyShortName} TCK comes with prebuilt test WAR files for
deployment on Java EE 8 RI , which provides a Servlet–compliant Web
deployment on Java EE 10 RI , which provides a Servlet–compliant Web
Copy link
Contributor

@gurunrao gurunrao Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change Java EE to Jakarta EE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@scottmarlow scottmarlow merged commit fb06e30 into jakartaee:master Apr 20, 2022
@scottmarlow
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants