-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JSTL TCK User Guide for Tags 3.0 #886
Conversation
17d97aa
to
d1d0798
Compare
Should also update the user_guides/jstl/src/main/jbake/content/install-server.inc which also still references |
d1d0798
to
2a6d091
Compare
Thanks for spotting that. I updated all
|
@volosied please let us know when you are done making changes so that we can do another review. Thanks! |
@scottmarlow Sure, let me take a look at this again. One question, should I specify only JDK 11 or should JDK 17 also be mention for the Java SEversion? I saw the TCK is run for both versions. |
@volosied Please do mention both JDK 11 and JDK 17 as the EE 10 release plan calls for both to be supported:
|
Section 4.1 Step 2 says: Should this be removed/edited since java 11 is the minimum for the TCK now? |
Removing sounds right as the ts.jte.jdk11 file was already merged with ts.jte in https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jstl/bin/ts.jte |
@pnicolucci @arjantijms Let me know if this looks good (or if any more changes are needed). Thanks |
@volosied can this pull request be updated to be |
@volosied I believe you're right -- I marked it as ready for review. Thank you. |
:CopyrightDates: 2017, 2021 | ||
:TechnologyRI: Eclipse GlassFish 6.1 | ||
:TechnologyVersion: 3.0 | ||
:ReleaseDate: March 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update to April
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to May instead as that month is more likely at this point.
@@ -23,7 +23,7 @@ published in a Java SE environment are located under | |||
`$TS_HOME/classes`. | |||
|
|||
The {TechnologyShortName} TCK comes with prebuilt test WAR files for | |||
deployment on Java EE 8 RI , which provides a Servlet–compliant Web | |||
deployment on Java EE 10 RI , which provides a Servlet–compliant Web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change Java EE to Jakarta EE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Started https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/106 to build the JSTL TCK |
~ Ready for Review ~
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow