Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp build hanging #43

Closed
wants to merge 2 commits into from
Closed

Gulp build hanging #43

wants to merge 2 commits into from

Conversation

devel-pa
Copy link

#32 fix + browserify-swap issue on windows.

@@ -35,7 +41,10 @@ gulp.task('styles', function() {
});

var bundler = _.memoize(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause issues

@devel-pa
Copy link
Author

The issue is caused by the fact that watchify is used for build, too.
In the way the gulpfile is done memoize is doing its job.
Refactoring the file with each task in a separate file and a config file for folders and files can be done later.

@devel-pa
Copy link
Author

Probably that area should be rewritten and create a bit more complex config based on gulp-if with a task for production.

Not mentioning that there are some deprecated stuff like gulp.start ( gulpjs/gulp#755 )

@rsumilang
Copy link
Contributor

I didn't notice this pull request when making my own hehe. I did my own version of the fix (#45) that doesn't change any of the current build tasks.

@jamiebuilds
Copy link
Owner

Closing in favor of #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants