Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlx postgres support #8

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sergiomeneses
Copy link

closes #7 .

@paulgb
Copy link
Member

paulgb commented Sep 16, 2024

Thanks for this, @sergiomeneses!

I've opened #9 as an alternative approach to this.

The advantages, as I see it, are:

  • This should work for all sqlx backends, without requiring us to create/maintain feature flags for each.
  • It should be future-proof for new major versions of sqlx, without requiring that we update fractional_index to point to the same dependency version.

The disadvantages are:

  • It requires an extra incantation when deriving AsRow
  • It doesn't work for Option<FractionalIndex>, though you can use it with a nullable column (it will return the default FractionalIndex when the column is null).

On net, I think the advantages outweigh the disadvantages, but I'm open to thoughts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SQLX - Postgres
2 participants