Merge pull request #2566 from softins/addendum-to-2564

Autobuild: Extend comments about macOS signing vs. CodeQL (from #2564)
jamulussoftware · Mar 30, 2022 · 4179ea5 · 4179ea5
2 parents eba94e2 + a389223
commit 4179ea5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/.github/workflows/autobuild.yml b/.github/workflows/autobuild.yml
@@ -127,10 +127,11 @@ jobs:
             # Stay on 10.15 as long as we use dmgbuild which does not work with 11's hdiutil (?):
             building_on_os:         macos-10.15
             base_command:           QT_VERSION=5.15.2 SIGN_IF_POSSIBLE=1 ./.github/autobuild/mac.sh
-            # Disable CodeQL on mac as it interferes with signing the binaries
+            # Disable CodeQL on mac as it interferes with signing the binaries (signing hangs, see #2563 and #2564)
             run_codeql:             false
             xcode_version:          12.1.1
 
+          # Reminder: If Legacy is removed, be sure to add a dedicated job for CodeQL again.
           - config_name:            MacOS Legacy (artifacts+CodeQL)
             target_os:              macos
             building_on_os:         macos-10.15