Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Reader Can't Access ledDelay and ledBuffers. #499

Closed
chigkim opened this issue Aug 7, 2020 · 4 comments
Closed

Screen Reader Can't Access ledDelay and ledBuffers. #499

chigkim opened this issue Aug 7, 2020 · 4 comments

Comments

@chigkim
Copy link
Contributor

chigkim commented Aug 7, 2020

In clientdlg.cpp, the following items are set.
ledDelay->setAccessibleName ( tr ( "Delay status LED indicator" ) );
ledBuffers->setAccessibleName ( tr ( "Buffers status LED indicator" ) );

However, they never gets updated, so screen reader users cannot access actual information.
For delay, CClientDlg::OnPingTimeResult should update ledDelay->setAccessibleDescription(tr("Green"));
For buffer, CClientDlg::OnTimerBuffersLED should update ledBuffers->setAccessibleDescription(tr("Green"));

@corrados
Copy link
Contributor

corrados commented Aug 7, 2020

What about the bars? Are the values of the bars is used by the screen reader, i.e., if you change the skin to Normal or Compact skin?

@chigkim
Copy link
Contributor Author

chigkim commented Aug 7, 2020 via email

corrados added a commit that referenced this issue Aug 10, 2020
@corrados
Copy link
Contributor

I have just added the setAccessibleDescription to the Delay and Buffer LEDs: a708a53
Can you please review and test the new code?

@corrados corrados added bug Something isn't working development in progress and removed bug Something isn't working labels Aug 10, 2020
@chigkim
Copy link
Contributor Author

chigkim commented Aug 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants