-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen Reader Can't Access ledDelay and ledBuffers. #499
Comments
What about the bars? Are the values of the bars is used by the screen reader, i.e., if you change the skin to Normal or Compact skin? |
I'm actually using normal skin.
On Mac, VoiceOver just announces them as "Image" regardless skin.
On fancy skin, they appear as multiple images, but still no value.
|
corrados
added a commit
that referenced
this issue
Aug 10, 2020
I have just added the setAccessibleDescription to the Delay and Buffer LEDs: a708a53 |
corrados
added
bug
Something isn't working
development in progress
and removed
bug
Something isn't working
labels
Aug 10, 2020
Thanks! Both read the colors!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In clientdlg.cpp, the following items are set.
ledDelay->setAccessibleName ( tr ( "Delay status LED indicator" ) );
ledBuffers->setAccessibleName ( tr ( "Buffers status LED indicator" ) );
However, they never gets updated, so screen reader users cannot access actual information.
For delay,
CClientDlg::OnPingTimeResult
should updateledDelay->setAccessibleDescription(tr("Green"));
For buffer,
CClientDlg::OnTimerBuffersLED
should updateledBuffers->setAccessibleDescription(tr("Green"));
The text was updated successfully, but these errors were encountered: