Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pl_PL app translation for 3.8.2 #2331

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

SeeLook
Copy link
Contributor

@SeeLook SeeLook commented Feb 2, 2022

Fixes #2306

Short description of changes

Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.8.2 milestone Feb 2, 2022
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by scanning through the translation ;-)

@@ -716,7 +716,7 @@
<message>
<location filename="../../clientdlg.cpp" line="727"/>
<source>%1 Directory</source>
<translation type="unfinished"></translation>
<translation>%1 Serwer</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: Server is not equivalent to directory.

</message>
<message>
<location filename="../../serverdlg.cpp" line="127"/>
<source>Recording has been switched off, either by the UI checkbox or SIGUSR2 being received</source>
<translation type="unfinished"></translation>
<translation>Nagrywanie zostało wyłączone przez użytkownika lub otrzymano komunikat SIGUSR2</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtinth (although unrelated to this PR) we need to update this if your PR #1975 gets merged: Recording has been switched off, by the UI checkbox, SIGUSR2 command or via JSON-RPC API

</message>
<message>
<location filename="../../serverdlg.cpp" line="148"/>
<source>Language</source>
<translation type="unfinished">Język</translation>
<translation>Język</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<translation>Język</translation>
<translation>Język (Lang)</translation>

I think @BLumia and I talked about adding (Lang) to the box to ensure people still understand it if the selected language is unknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand from where those 'unfinished' entries came. Either QtLinguist shows all done and text editor search finds none.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in @ann0see's comment above? That's just the diff. The red part shows what it looked like before your changes (= what has been removed), and the green part shows the new parts. So everything is fine. :)

@ann0see Would it make sense to solve this (lang) thing in the code instead of asking all translators to add it? Or would you only add it for translations which don't contain *Lang*?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably adding it to the code would be good; however this would also show it in English then.

src/res/translation/translation_pl_PL.ts Show resolved Hide resolved
@hoffie hoffie mentioned this pull request Feb 2, 2022
2 tasks
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot!

  • Translator listed in the src/util.cpp, optionally add link to PR or code
  • Punctuation and spacing consistent.
  • Signal words consistent (“ASIO”, “Buffer”)
  • App translations: No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)
  • Installer translations: Passes tools/check-wininstaller-translations.sh

Note: Should be squash-merged. Leaving the merge to @ann0see.

@ann0see ann0see merged commit 8932460 into jamulussoftware:master Feb 2, 2022
@SeeLook SeeLook deleted the translation_pl_PL_v3.8.2 branch February 9, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pl_PL app translation for 3.8.2
3 participants